Page MenuHomePhabricator

TemplateWizard: Design fixups for template search
Closed, ResolvedPublic2 Estimated Story Points

Description

This is not really a redesign but applying fixes to technical issues:

  • When searching for a template, the dropdown items show TemplateData descriptions untruncated. Very long descriptions make the items extremely large.
  • Several places in the UI (not only while searching for a template but also in the actual editor) have issues with very long words. Horizontal scrollbars appear.
  • The subtitle shows the TemplateData description and optional redirect information. The font size is extremely small.

Patch-For-Review:

Design decisions made in this patch:

  • I decided to show at most 2 lines from the template description.
  • The font size for the subtitles in the dropdown is the same as later in the dialog.
  • In the dropdown, long words are truncated. This allows to see the text that follows the long word. In the dialog, long words wrap. Here the user can scroll.

Extreme example, before vs. after:

Screenshot from 2021-06-14 09-15-49.png (356×717 px, 62 KB)

Screenshot from 2021-06-14 09-18-29.png (129×723 px, 7 KB)

Screenshot from 2021-06-14 09-16-29.png (161×716 px, 18 KB)

Screenshot from 2021-06-14 09-18-40.png (162×716 px, 19 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is not really "unplanned". It's part of T274907. I opened a subticket mostly to have a better place to show the screenshots.

I would consider it unplanned sprint work because:

  1. The changes and the ticket we're not discussed or added to the backlog during sprint planning
  2. It has additional points associated with it that we're not estimated during story time/sprint planning (the parent ticket was added to the sprint with 1 point left, to backport completed changes, and as far as I've understood these are additional changes with 2 additional points)

I've only added it for visibility - fundamentally I think it's not problematic to have and prioritise unplanned sprint work as long as we discuss it, agree on it, and make it visible.

Change 699159 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TemplateWizard@master] Fix design issues related to template descriptions

https://gerrit.wikimedia.org/r/699159

Change 700064 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Add missing word wrapping to template/param descriptions

https://gerrit.wikimedia.org/r/700064

Just a follow-up note to our conversation so it's documented on the ticket - design-wise it looks like a helpful improvement as shown in the screenshots and I wouldn't make further changes to it.

Change 700064 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add missing word wrapping to template/param descriptions

https://gerrit.wikimedia.org/r/700064

Change 699159 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Fix design issues related to template descriptions

https://gerrit.wikimedia.org/r/699159