Centralised notice extension (Homepage)
To make a confidential Fundraising task, visible only to members of acl*WMF-FR click here: https://phabricator.wikimedia.org/maniphest/task/create/?template=89899
Details
Details
Yesterday
Yesterday
Pcoombe renamed T127011: Banner device and anonymous/logged-in settings should be set at campaign level from Banner device settings should be set at campaign level to Banner device and anonymous/logged-in settings should be set at campaign level.
Tue, Jul 30
Tue, Jul 30
Pppery removed a project from T47920: Don't enable API modules on wikis where they aren't used: good first task.
Pppery added a comment to T371293: CentralNotice should not unconditionally link to documentation on Meta-Wiki.
There are also some suspicious code comments here ...
// For now, we want to make this display without paging on // meta.wikimedia.org, in line with the functionality that users currently // encounter. // This should be enough--Meta has less than 500 campaigns. private const DEFAULT_LIMIT = 5000;
meta.wikimedia.org probably has more than 500 campaigns now (every fundraiser year creates many) and why only care about Meta
Mon, Jul 29
Mon, Jul 29
gerritbot added a comment to T360668: Drop support for non-Codex message boxes.
Change #1057959 had a related patch set uploaded (by Abaris; author: Abaris):
[mediawiki/extensions/GrowthExperiments@master] Convert maybeShowWarning message boxes to Codex styles
Mon, Jul 29, 9:25 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), WMDE-TechWish-Maintenance, MassMessage, Two-Column-Edit-Conflict-Merge, GrowthExperiments, MediaWiki-extensions-Graph, MediaWiki-extensions-FlaggedRevs, MediaWiki-extensions-CentralNotice, StructuredDiscussions, MediaWiki-extensions-Translate, Growth-Team
Mon, Jul 29, 7:12 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), WMDE-TechWish-Maintenance, MassMessage, Two-Column-Edit-Conflict-Merge, GrowthExperiments, MediaWiki-extensions-Graph, MediaWiki-extensions-FlaggedRevs, MediaWiki-extensions-CentralNotice, StructuredDiscussions, MediaWiki-extensions-Translate, Growth-Team
gerritbot added a comment to T360668: Drop support for non-Codex message boxes.
Change #1057938 had a related patch set uploaded (by Abaris; author: Abaris):
[mediawiki/extensions/CentralNotice@master] Convert setValidationError message boxes to use Codex styles
Mon, Jul 29, 7:12 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), WMDE-TechWish-Maintenance, MassMessage, Two-Column-Edit-Conflict-Merge, GrowthExperiments, MediaWiki-extensions-Graph, MediaWiki-extensions-FlaggedRevs, MediaWiki-extensions-CentralNotice, StructuredDiscussions, MediaWiki-extensions-Translate, Growth-Team
Dogu added a comment to T360668: Drop support for non-Codex message boxes.
The update for FlaggedRevs to use Codex message boxes has been completed as part of task T191156.
Mon, Jul 29, 5:45 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), WMDE-TechWish-Maintenance, MassMessage, Two-Column-Edit-Conflict-Merge, GrowthExperiments, MediaWiki-extensions-Graph, MediaWiki-extensions-FlaggedRevs, MediaWiki-extensions-CentralNotice, StructuredDiscussions, MediaWiki-extensions-Translate, Growth-Team
Dogu updated the task description for T360668: Drop support for non-Codex message boxes.
Mon, Jul 29, 5:44 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.6; 2024-05-21), WMDE-TechWish-Maintenance, MassMessage, Two-Column-Edit-Conflict-Merge, GrowthExperiments, MediaWiki-extensions-Graph, MediaWiki-extensions-FlaggedRevs, MediaWiki-extensions-CentralNotice, StructuredDiscussions, MediaWiki-extensions-Translate, Growth-Team
Fri, Jul 26
Fri, Jul 26
gerritbot added a comment to T361680: CentralNotice should catch banner errors and log them to its own channel.
Change #1016759 abandoned by Jdlrobson:
[mediawiki/extensions/CentralNotice@master] Log central notice banner errors to their own channel
Reason:
See https://phabricator.wikimedia.org/T361680#9940111 for new proposal which requires modification to how the banners are added to the page.
Jdlrobson added a comment to T361680: CentralNotice should catch banner errors and log them to its own channel.
@Pcoombe what do you think of the above proposal? Is it viable?
Thu, Jul 25
Thu, Jul 25
Jdlrobson moved T365324: CentralNotice needs a dark treatment from Backlog to Web (MediaWiki) on the dark-mode board.
Wed, Jul 24
Wed, Jul 24
DerHexer updated subscribers of T370798: Create a preview sandbox for Central Notice banner designs.
Tue, Jul 23
Tue, Jul 23
Mon, Jul 22
Mon, Jul 22
Maintenance_bot removed a project from T354875: build: Update SVGO to latest v3.2.0 in Wikimedia deployed repos: Patch-For-Review.
Mon, Jul 22, 9:33 PM · MediaWiki-General, GrowthExperiments, Notifications, NearbyPages, TimedMediaHandler, VisualEditor, Timeless, UniversalLanguageSelector, MediaWiki-extensions-Translate, Thanks, MediaViewer, MediaWiki-extensions-CentralNotice, ChessBrowser, Maps (Kartographer), MediaWiki-extensions-GuidedTour, Desktop Improvements (Vector 2022), MinervaNeue, Two-Column-Edit-Conflict-Merge, Revision-Slider, Page-Previews, Growth-Team, MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), Wikimedia-Performance-recommendation, SVG
Maintenance_bot removed a project from T338447: Update CentralNotice to use the new HookContainer/HookRunner system: Patch-For-Review.
Maintenance_bot removed a project from T350965: Use expression builder instead of raw SQL in CentralNotice: Patch-For-Review.
gerritbot added a comment to T354875: build: Update SVGO to latest v3.2.0 in Wikimedia deployed repos.
Change #1052668 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy
Mon, Jul 22, 8:58 PM · MediaWiki-General, GrowthExperiments, Notifications, NearbyPages, TimedMediaHandler, VisualEditor, Timeless, UniversalLanguageSelector, MediaWiki-extensions-Translate, Thanks, MediaViewer, MediaWiki-extensions-CentralNotice, ChessBrowser, Maps (Kartographer), MediaWiki-extensions-GuidedTour, Desktop Improvements (Vector 2022), MinervaNeue, Two-Column-Edit-Conflict-Merge, Revision-Slider, Page-Previews, Growth-Team, MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), Wikimedia-Performance-recommendation, SVG
gerritbot added a comment to T312369: Migrate usage of Database::select to SelectQueryBuilder in CentralNotice.
Change #1052668 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy
gerritbot added a comment to T350965: Use expression builder instead of raw SQL in CentralNotice.
Change #1052668 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy
gerritbot added a comment to T338447: Update CentralNotice to use the new HookContainer/HookRunner system.
Change #1052668 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy
gerritbot added a comment to T357339: PHP Fatal error: Cannot declare class HookRunnerTest, because the name is already in use.
Change #1052668 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy
gerritbot added a comment to T357635: Replace usage of wfGetDB() in CentralNotice before the 1.42 cut so it can be hard-deprecated.
Change #1052668 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy
Ejegg added a comment to T366742: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setPageTitle with Message argument was deprecated in MediaWiki 1.41. [Called from SpecialCentralNoticeBanners::execute].
Sorry for the delay reviewing that merge! I've finished looking it over and smoke testing locally, and have given it C+2.
Andrew added a comment to T360949: Upgrade centralnotice-staging to get off debian buster.
I shut down this VM due to lack of response here
Pcoombe updated the task description for T367189: CentralNotice admin interface issues in dark mode.
Sun, Jul 21
Sun, Jul 21
Umherirrender closed T350965: Use expression builder instead of raw SQL in CentralNotice as Resolved.
Thu, Jul 18
Thu, Jul 18
thcipriani added a project to T366742: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setPageTitle with Message argument was deprecated in MediaWiki 1.41. [Called from SpecialCentralNoticeBanners::execute]: Fundraising Tech - Chaos Crew.
Wed, Jul 17
Wed, Jul 17
Mon, Jul 15
Mon, Jul 15
Lucas_Werkmeister_WMDE added a comment to T366742: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setPageTitle with Message argument was deprecated in MediaWiki 1.41. [Called from SpecialCentralNoticeBanners::execute].
Actually, it looks like this merge includes the fix, so IIUC that will roll out with this week’s train.
Lucas_Werkmeister_WMDE added a comment to T366742: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setPageTitle with Message argument was deprecated in MediaWiki 1.41. [Called from SpecialCentralNoticeBanners::execute].
This is still cluttering logspam-watch during deployments two months after it was fixed on the master branch. Can someone who knows how to deploy changes to CentralNotice please get the fix deployed?
Thu, Jul 11
Thu, Jul 11
Jdlrobson moved T367189: CentralNotice admin interface issues in dark mode from Backlog to Web (MediaWiki) on the dark-mode board.
Wed, Jul 10
Wed, Jul 10
Tue, Jul 9
Tue, Jul 9
phuedx added a comment to T361680: CentralNotice should catch banner errors and log them to its own channel.
No need for a RegEx. A little DOMDocument magic in BannerRenderer should do: