Page MenuHomePhabricator

Use CheckboxMultiSelectWidget (when it exists) in HTMLMultiSelectField
Closed, ResolvedPublic

Description

Use CheckboxMultiSelectWidget (when it exists) in HTMLMultiSelectField. We wouldn't need custom style overrides then (like a8ae2208cec8914028ce260c1b2f00a92e7e2127).

Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added subscribers: matmarex, Jdforrester-WMF.
Jdforrester-WMF set Security to None.

Change 291714 had a related patch set uploaded (by Bartosz Dziewoński):
HTMLMultiSelectField: Use CheckboxMultiselectInputWidget

https://gerrit.wikimedia.org/r/291714

Change 291714 merged by jenkins-bot:
HTMLMultiSelectField: Use CheckboxMultiselectInputWidget

https://gerrit.wikimedia.org/r/291714

Sethakill subscribed.

This change will broke pages with this field and flatlist parameter.

wmf.4master
T123935 wmf.4.png (750×1 px, 112 KB)
T123935 master.png (750×1 px, 76 KB)

Change 292947 had a related patch set uploaded (by Bartosz Dziewoński):
HTMLForm: Properly support 'flatlist' in OOUI mode

https://gerrit.wikimedia.org/r/292947

Change 292947 merged by jenkins-bot:
HTMLForm: Properly support 'flatlist' in OOUI mode

https://gerrit.wikimedia.org/r/292947

Sethakill removed a project: Patch-For-Review.
Sethakill removed a subscriber: gerritbot.

Updated screenshot for those who are interested:

Screen Shot 2016-06-06 at 16.49.41.png (479×1 px, 56 KB)