Page MenuHomePhabricator

Spelling variant of the Lemma - Access documentation if spelling variant isn’t available
Closed, ResolvedPublic5 Estimated Story Points

Description

As a Lexeme creator I want to understand what to do in case the spelling variant I am looking for can’t be chosen in the spelling variant selector in order to be able to rectify the issue and enter correct data for my Lexeme.

Problem:
We need to let people access documentation for what to do when they can’t find the spelling variant they are looking for.

Screenshots/mockups:
https://www.figma.com/file/XoYktoKEBnC0VIf1SRuxJK/Lexicographical-Data-UI?node-id=1439%3A3552

BDD
GIVEN the Special:NewLexeme page
WHEN entering a spelling variant
THEN there is a pseudo-entry in the drowpdown leading to documentation

Acceptance criteria:

  • pseudo-entry is added to the spelling variant selector
  • entry leads to documentation for spelling variants

Notes:

Event Timeline

That Figma-Link doesn't seem to show that pseudo-entry @Erdinc_Ciftci_WMDE

@Erdinc_Ciftci_WMDE question that came up today: Do we always show the entry or only when there are no search results? Thoughts?

@Sarai-WMDE Do WiKit Lookups already support adding an arbitrary link to the list of options, or do we need to expand the component in order to support that?

Hey @ItamarWMDE 👋🏻 I can't be 100% sure, but I'd say this is currently not feasible 🤔 In order to display the link I'd say we'd have to add a "footer" slot in the OptionsMenu component, or introduce that logic in the LookupInput component. In Codex, we did something similar to the latter with TypeaheadSearch (see code). Although I'm seeing now, thanks to this example, that the former might make more sense.

On a design side note, @Erdinc_Ciftci_WMDE : If we add this footer, it should display a "divider" (top border) so it can be differentiated from the menu options (see screenshot below, designs here). I'm also assuming that the footer would remain visible at all times, since it would be fixed and outside of the scroll area.

Screenshot 2022-05-09 at 12.43.56.png (1×1 px, 173 KB)

Hello,

I will provide the design but before that wanted to clarify it a bit in written form.

This feature was in the usability tests we conducted but then before all the hike started while writing tickets we discovered It would be complex with WiKit and removed this from the prototype. So before I go ahead with providing new things wanted to be sure that here that we are on the same page.

The new plan is to put this help somewhere else right, either next to the input field title or in the infobox, etc. @ItamarWMDE
@Lydia_Pintscher ?

I will work on a design accordingly ☺️

That's the idea, or at least, that would be much more technically feasible. Although I leave the final decision to @Lydia_Pintscher since she is the product owner.

The new plan is to put this help somewhere else right, either next to the input field title or in the infobox, etc. @ItamarWMDE
@Lydia_Pintscher ?

Ok yeah let's do that then.
I'd go with next to the input field instead of the infobox because most people should not see it and should not need to care about it. So I'd only show it when it's actually needed, so earliest when the spelling variant input field is shown.

sprint 10 planning:
when line is too long: get clarification from UX (..., line break, or something else?)

@Erdinc_Ciftci_WMDE: Two things that came up today:t for you:

  • We can not find the new message/mockup on figma. Can you please have another look and fix the link?
  • What happens when the string is too long to fit in one line? Do we use an elipsis, a line break or something else?

Change 805811 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Add link text copy for the docs of the spelling variant input

https://gerrit.wikimedia.org/r/805811

Change 805811 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add link text copy for the docs of the spelling variant input

https://gerrit.wikimedia.org/r/805811

PR: https://github.com/wmde/new-lexeme-special-page/pull/235

Open question: Should that target of that help link be configurable, or can we just hard-code it?

Change 806936 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Add url for documentation about spelling variant as message

https://gerrit.wikimedia.org/r/806936

Change 806936 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add url for documentation about spelling variant as message

https://gerrit.wikimedia.org/r/806936

Change 807141 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Bump Special:NewLexemeAlpha

https://gerrit.wikimedia.org/r/807141

Change 807141 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Bump Special:NewLexemeAlpha

https://gerrit.wikimedia.org/r/807141