Page MenuHomePhabricator
Create Task
Maniphest T284611

Selenium tests for add link feature
Closed, ResolvedPublic
Actions

Description

There are a lot of moving parts with homepage code, VE, dialogs, etc, having some coverage of this via browser tests would be nice.

TBD is which specific components we want to try to target

Details

SubjectRepoBranchLines +/-
selenium: Conditionally load Parsoidmediawiki/extensions/GrowthExperimentsmaster+5 -3
zuul: Add VisualEditor/parsoid dependencies to GrowthExperimentsintegration/configmaster+1 -1
selenium: Test for AddLinkmediawiki/extensions/GrowthExperimentsmaster+2 K -14 K
selenium: AddLink configured Special:Homepagemediawiki/extensions/GrowthExperimentsmaster+1 K -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Jun 8 2021, 9:11 PM
gerritbot added a comment.Jun 8 2021, 9:13 PM

Change 698872 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Add basic workflow test for add link feature

https://gerrit.wikimedia.org/r/698872

gerritbot added a project: Patch-For-Review.Jun 8 2021, 9:13 PM
zeljkofilipin subscribed.Jun 9 2021, 9:26 AM
kostajh claimed this task.Jun 9 2021, 9:43 AM
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
zeljkofilipin added a project: User-zeljkofilipin.Jun 9 2021, 10:00 AM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
DannyS712 mentioned this in T284634: Create phabricator project for task about selenium tests and related.Jun 9 2021, 10:09 AM
zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.Jun 9 2021, 12:29 PM
kostajh triaged this task as Medium priority.Jun 10 2021, 8:58 AM
DannyS712 added a project: Browser-Tests.Jun 14 2021, 5:38 AM
gerritbot added a comment.Jun 14 2021, 8:54 AM

Change 699705 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Test for AddLink

https://gerrit.wikimedia.org/r/699705

gerritbot added a comment.Jun 18 2021, 1:31 PM

Change 698872 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] selenium: AddLink configured Special:Homepage

https://gerrit.wikimedia.org/r/698872

kostajh lowered the priority of this task from Medium to Low.Jun 28 2021, 9:03 AM
kostajh moved this task from In Progress to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.

Stalled on T285649: Switch all Quibble Selenium and api-testing jobs to use apache. We need apache in order for VisualEditor + Parsoid to work in CI.

kostajh mentioned this in T276860: Review test coverage for add link feature.Jun 28 2021, 10:34 AM
In T284611#7180064, @kostajh wrote:

Stalled on T285649: Switch all Quibble Selenium and api-testing jobs to use apache. We need apache in order for VisualEditor + Parsoid to work in CI.

Although, we could still add tests for the No suggestions dialog,

kostajh raised the priority of this task from Low to Medium.Jul 2 2021, 8:35 AM
kostajh changed the task status from Open to Stalled.Sep 13 2021, 10:15 AM
kostajh edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).
In T284611#7180064, @kostajh wrote:

Stalled on T285649: Switch all Quibble Selenium and api-testing jobs to use apache. We need apache in order for VisualEditor + Parsoid to work in CI.

Moving out of the current sprint due to this.

kostajh moved this task from Inbox to Triaged on the Growth-Team board.Sep 13 2021, 10:15 AM
zeljkofilipin added a comment.Sep 14 2021, 11:33 AM
In T284611#7347737, @kostajh wrote:
In T284611#7180064, @kostajh wrote:

Stalled on T285649: Switch all Quibble Selenium and api-testing jobs to use apache. We need apache in order for VisualEditor + Parsoid to work in CI.

Moving out of the current sprint due to this.

Maybe I'm not understanding this correctly, but looks like VisualEditor (and Parsoid?) work in CI, see 345146.

kostajh added a comment.Sep 14 2021, 11:36 AM
In T284611#7351634, @zeljkofilipin wrote:
In T284611#7347737, @kostajh wrote:
In T284611#7180064, @kostajh wrote:

Stalled on T285649: Switch all Quibble Selenium and api-testing jobs to use apache. We need apache in order for VisualEditor + Parsoid to work in CI.

Moving out of the current sprint due to this.

Maybe I'm not understanding this correctly, but looks like VisualEditor (and Parsoid?) work in CI, see 345146.

Yeah, now I am confused. Because my test would definitely just hang in CI, but it was also not possible (maybe you know a way?) to capture the browser console logs to see what the specific error was.

Also, for your test, I think it's possible that edit interactions specifically won't work -- I'm curious to see what happens when the Selenium test presses the Publish button.

gerritbot added a comment.Sep 14 2021, 4:41 PM

Change 721024 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

https://gerrit.wikimedia.org/r/721024

zeljkofilipin added a comment.Sep 14 2021, 4:42 PM
In T284611#7351636, @kostajh wrote:

Also, for your test, I think it's possible that edit interactions specifically won't work -- I'm curious to see what happens when the Selenium test presses the Publish button.

Let's see: 721024.

zeljkofilipin added a comment.Sep 14 2021, 4:47 PM
In T284611#7351636, @kostajh wrote:

Yeah, now I am confused. Because my test would definitely just hang in CI, but it was also not possible (maybe you know a way?) to capture the browser console logs to see what the specific error was.

It might be possible with addConsoleLogs. You'll have to use spec reported instead of the default dot reporter, but that should be a simple configuration change. I would make a commit testing it, but I don't know what you would like to capture. Let me know if you need help. Feel free to set up a video meeting (my calendar is usually up to date) if you would like to pair on this.

zeljkofilipin moved this task from Watching 📺 to Waiting 🏹 on the User-zeljkofilipin board.Sep 14 2021, 4:47 PM
zeljkofilipin added a comment.Sep 14 2021, 5:07 PM
In T284611#7352516, @zeljkofilipin wrote:
In T284611#7351636, @kostajh wrote:

Also, for your test, I think it's possible that edit interactions specifically won't work -- I'm curious to see what happens when the Selenium test presses the Publish button.

Let's see: 721024.

Nothing exploded, but it either didn't save or it takes a very long time to save. I'll further increase timeout, but I don't have much hope it will help.

zeljkofilipin moved this task from Waiting 🏹 to Deep work 🌊 on the User-zeljkofilipin board.Sep 14 2021, 5:08 PM
gerritbot added a comment.Sep 15 2021, 3:04 PM

Change 721024 abandoned by Zfilipin:

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

Reason:

just a test

https://gerrit.wikimedia.org/r/721024

zeljkofilipin moved this task from Deep work 🌊 to Backlog 🪒 on the User-zeljkofilipin board.Sep 15 2021, 3:07 PM

Looks like VisualEditor doesn't work in CI. See T284165#7355537.

gerritbot added a comment.Sep 16 2021, 10:29 AM

Change 721024 restored by Kosta Harlan:

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

https://gerrit.wikimedia.org/r/721024

gerritbot added a comment.Sep 16 2021, 10:36 AM

Change 721024 abandoned by Kosta Harlan:

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

Reason:

https://gerrit.wikimedia.org/r/721024

gerritbot added a comment.Oct 7 2021, 1:22 PM

Change 721024 restored by Zfilipin:

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

https://gerrit.wikimedia.org/r/721024

gerritbot added a comment.Oct 7 2021, 1:23 PM

Change 721024 abandoned by Zfilipin:

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

Reason:

https://gerrit.wikimedia.org/r/721024

zeljkofilipin removed a project: User-zeljkofilipin.Oct 7 2021, 5:58 PM
gerritbot added a comment.Nov 22 2021, 12:31 PM

Change 721024 restored by Zfilipin:

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

https://gerrit.wikimedia.org/r/721024

gerritbot added a comment.Nov 22 2021, 12:32 PM

Change 721024 abandoned by Zfilipin:

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

Reason:

https://gerrit.wikimedia.org/r/721024

gerritbot added a comment.Dec 1 2021, 10:40 AM

Change 742939 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] zuul: Add VisualEditor/parsoid dependencies to GrowthExperiments

https://gerrit.wikimedia.org/r/742939

gerritbot added a comment.Dec 10 2021, 10:45 AM

Change 721024 restored by Kosta Harlan:

[mediawiki/extensions/VisualEditor@master] WIP VisualEditor should save an edit

https://gerrit.wikimedia.org/r/721024

kostajh changed the task status from Stalled to Open.Jan 5 2022, 11:36 AM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

This test passes now that T285649: Switch all Quibble Selenium and api-testing jobs to use apache is done.

gerritbot added a comment.Jan 8 2022, 1:48 AM

Change 699705 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] selenium: Test for AddLink

https://gerrit.wikimedia.org/r/699705

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 8 2022, 2:00 AM
gerritbot added a comment.Jan 10 2022, 9:46 AM

Change 752616 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Remove Parsoid loading code

https://gerrit.wikimedia.org/r/752616

gerritbot added a comment.Jan 10 2022, 10:01 AM

Change 742939 merged by jenkins-bot:

[integration/config@master] zuul: Add VisualEditor/parsoid dependencies to GrowthExperiments

https://gerrit.wikimedia.org/r/742939

gerritbot added a comment.Jan 10 2022, 3:30 PM

Change 752616 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] selenium: Conditionally load Parsoid

https://gerrit.wikimedia.org/r/752616

• Urbanecm_WMF changed the task status from Open to In Progress.Jan 31 2022, 11:34 AM
zeljkofilipin added a comment.Feb 28 2022, 3:54 PM

Is this a duplicate (or a subtask) of T296187: Selenium Tests for VisualEditor.

zeljkofilipin added a parent task: T296187: Selenium Tests for VisualEditor.Feb 28 2022, 3:54 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 18 2022, 1:33 PM
In T284611#7741795, @zeljkofilipin wrote:

Is this a duplicate (or a subtask) of T296187: Selenium Tests for VisualEditor.

No, it's something specific to a GrowthExperiments plugin that uses VE.

@Etonkovidova not sure there is anything to QA here; we have selenium tests for add link now.

zeljkofilipin added a comment.Apr 8 2022, 1:56 PM

@kostajh should this task be resolved?

kostajh closed this task as Resolved.Apr 8 2022, 8:34 PM
In T284611#7840918, @zeljkofilipin wrote:

@kostajh should this task be resolved?

Yes, I think so. Thanks!

zeljkofilipin awarded a token.Apr 11 2022, 11:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits