Expose mathoid warnings via restbase
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Physikerwelt
	Jun 4 2019, 9:30 PM

Description

In https://gerrit.wikimedia.org/r/#/c/mediawiki/services/mathoid/+/447558/3/test/features/math/simple.js the warning feature was implemented. In https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/442124/ the warnings are displayed as tracking categories. However, in the middle, I guess in restbase the information is lost. For testcase

curl -X POST "https://en.wikipedia.org/api/rest_v1/media/math/check/chem" -d "type=chem&q=\ce {pH=-\log _{10}[H+]}"
{"success":true,"checked":"{\\ce {pH=-\\log _{10}[H]}}","requiredPackages":["mhchem"],"identifiers":["p","H","H"],"endsWithDot":false}

I do not see a warning. I guess somewhere in this file
https://github.com/wikimedia/restbase/blame/master/v1/mathoid.yaml
or close to this file one need to specify that the warning field is preserved.

I do not exactly know how to do that. @mobrovac @Pchelolo @Clarakosi any idea?

Related Objects
Search...

Status	Assigned	Task
Resolved	Physikerwelt	T195861 Create a committee to improve the math support in Wikimedia projects
Resolved	Physikerwelt	T197842 Deprecate texvc commands conflicting with LaTeX commands used in common packages
Resolved	• mobrovac	T225030 Expose mathoid warnings via restbase

Event Timeline

Physikerwelt created this task.Jun 4 2019, 9:30 PM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptJun 4 2019, 9:30 PM

There's something weird in the Mathoid deployment here. When I issue the same request from inside production directly to Mathoid, the warnings are not returned either:

$ curl 'http://mathoid.discovery.wmnet:10042/texvcinfo' -XPOST -H'Content-Type: application/json' -d'{"q":"\\ce {pH=-\\log _{10}[H+]}", "type":"chem"}'
{"success":true,"checked":"{\\ce {pH=-\\log _{10}[H+]}}","requiredPackages":["mhchem"],"identifiers":["p","H","H"],"endsWithDot":false}

This is not the case locally, where I do get warnings for this query. It seems that the latest version of Mathoid is not deployed in production. I will take a moment and see with @akosiaris why that is the case.

There is a second issue here, which we will encounter once the above is resolved. Namely, RESTBase stores the results of the checks, which means that these warnings will appear only for new formulae. What we can do there is go over all of the stored formulae and re-issue the requests for them to get the latest content.

• mobrovac claimed this task.Jun 5 2019, 9:26 AM

Physikerwelt awarded a token.Jun 5 2019, 9:57 AM

The first part of the issue has been fixed; Mathoid's code is up to date now. However, the results will only be publicly visible for new formulae. I'll run a dump of all of the formulae in storage next week.

Great thank you. I just confirmed that it works for new formulae.

curl -X POST "https://en.wikipedia.org/api/rest_v1/media/math/check/chem" -d "type=chem&q=\ce {pH=-\log _{10}[H+]+20190606}"
{"success":true,"checked":"{\\ce {pH=-\\log _{10}[H]20190606}}","requiredPackages":["mhchem"],"identifiers":["p","H","H"],"endsWithDot":false,"warnings":[{"type":"mhchem-deprecation","details":{"error":{"message":"Expected [a-zA-Z] but \" \" found.","expected":[{"type":"class","parts":[["a","z"],["A","Z"]],"inverted":false,"ignoreCase":false}],"found":" ","location":{"start":{"offset":13,"line":1,"column":14},"end":{"offset":14,"line":1,"column":15}},"name":"SyntaxError"},"success":false,"warnings":[],"status":"S","details":"SyntaxError: Expected [a-zA-Z] but \" \" found.","offset":13,"line":1,"column":14}}]}

The tracking category works as well https://en.wikipedia.org/w/index.php?title=Category:Pages_that_use_a_deprecated_format_of_the_chem_tags&action=edit&redlink=1

All of the formulae have been rechecked, so warnings should now be emitted for all requests. Since we updated Mathoid to the latest code, I have also regenerated all of the renders to match the current expectations.

Fun fact: we have 10M unique formulae in storage! :)

Aklapper added a project: Math.Jun 24 2020, 5:53 AM

Expose mathoid warnings via restbaseClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Expose mathoid warnings via restbase
Closed, ResolvedPublic
Actions

Related Objects
Search...