Translate extension needs to import mediawiki.skin.variables to get night mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 1 2024, 12:11 AM

Description

NOTE: Blocks deployment on www.mediawiki.org accounting for 56% of all color contrast violations there.

I was surprised that translate extension was still not getting night mode and realized the root cause was a FIXME in the codebase that ties it to a static import of the CSS variables to provide support for LTS v1.42.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1007399/2/resources/css/ext.translate.tag.languages.less#b1

Steps to replicate the issue (include links if applicable):

Visit https://m.mediawiki.org/w/index.php?title=Reading/Web/Accessibility_for_reading&minervanightmode=1

What happens?:

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Other Assignee: abi_

	Subject	Repo	Branch	Lines +/-
	Address TODO, address color contrast issues in night mode	mediawiki/extensions/Translate	master	+14 -301

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved		ovasileva	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Resolved		Jdlrobson	T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
Resolved		ovasileva	T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
Resolved	BUG REPORT	Jdlrobson	T358822 Translate extension needs to import mediawiki.skin.variables to get night mode

Event Timeline

Jdlrobson created this task.Mar 1 2024, 12:11 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMar 1 2024, 12:11 AM

Jdlrobson added a project: FY2023-24-WE 2.1 Typography and palette customizations.Mar 1 2024, 12:11 AM

Change 1007399 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Translate@master] Address FIXME, support night mode

https://gerrit.wikimedia.org/r/1007399

gerritbot added a project: Patch-For-Review.Mar 1 2024, 12:12 AM

Tacsipacsi subscribed.Mar 1 2024, 9:26 AM

Jdlrobson added a project: Language-Team.Mar 1 2024, 5:12 PM

Blocking from enabling night mode on MediaWiki.org.

Need to test patch with MW 1.40

abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2024-January-March) board.Mar 7 2024, 5:14 AM

• Nikerabbit added projects: Unplanned-Sprint-Work, Localization Infrastructure FY2023-24.Mar 7 2024, 5:56 AM

• Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Mar 7 2024, 8:33 AM

• Nikerabbit moved this task from Backlog to Translatable pages (LH1) on the Localization Infrastructure FY2023-24 board.Mar 7 2024, 9:57 AM

Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 8 2024, 12:10 AM

Jdlrobson added a parent task: T354843: [Night mode] Make all open-by-default global navigation appear in night mode on mobile.Mar 8 2024, 11:59 PM

Jdlrobson updated the task description. (Show Details)

Change 1007399 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Address TODO, address color contrast issues in night mode

https://gerrit.wikimedia.org/r/1007399

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2024, 6:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 11 2024, 7:01 PM

abi_ assigned this task to Jdlrobson.Mar 12 2024, 2:12 AM

abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2024-January-March) board.

abi_ updated Other Assignee, added: abi_.

Jdlrobson lowered the priority of this task from High to Medium.Mar 12 2024, 5:28 PM

https://m.mediawiki.org/w/index.php?title=Reading/Web/Accessibility_for_reading&minervanightmode=1 looks good (apart from the two edit links which look redundant, but not related to this task)

Thank you language team for prioritizing this work!

	F42269146: Screenshot 2024-02-29 at 4.11.34 PM.png
	Mar 1 2024, 12:11 AM

	F42269132: Screenshot 2024-02-29 at 4.11.01 PM.png
	Mar 1 2024, 12:11 AM

	F42622513: image.png
	Mar 14 2024, 3:21 PM

Translate extension needs to import mediawiki.skin.variables to get night modeClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Translate extension needs to import mediawiki.skin.variables to get night mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Related Objects
Search...