Maniphest T359081

[Bug] Page previews currently does not work in night mode.
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 4 2024, 4:50 PM

Tags

Referenced Files

	F43467188: screenshot 127.png
	Mar 26 2024, 10:14 PM

	F42736315: screenshot 52.png
	Mar 18 2024, 11:30 PM

	F42396421: image.png
	Mar 4 2024, 4:50 PM

Subscribers

Masumrezarock100

Description

Page previews currently does not work in night mode.

Steps to reproduce

#Visit mobile site, and enable night mode

Hover over link

Expected results

Description of what should have happened.

Actual results

Page previews currently does not work in night mode.

image.png (1×1 px, 607 KB)

Environments observed

Browser version:
OS version:
Device model:
Device language:

Check any additional observations

Observed on the beta cluster wiki
Observed on a production wiki
Observed on Vector desktop skin
Observed on MinervaNeue responsive skin
Observed while logged in
Observed while not logged in (anonymous)

Stack trace

Console output

QA Results - Beta

AC	Status	Details
1	✅	T359081#9640424

QA Results - Prod

AC	Status	Details
1	✅	T359081#9663937

Details

	Subject	Repo	Branch	Lines +/-
	Fix popups night mode	mediawiki/extensions/Popups	master	+51 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
		Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
		Resolved		ovasileva	T354835 [epic] Release night mode as a beta feature on desktop and mobile
		Resolved		Jdlrobson	T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
		Resolved		ovasileva	T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
		Resolved	BUG REPORT	ovasileva	T359081 [Bug] Page previews currently does not work in night mode.
		Resolved		Jdlrobson	T360877 [Bug] Page previews gradient not working in night mode

Event Timeline

Jdlrobson created this task.Mar 4 2024, 4:50 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMar 4 2024, 4:50 PM

Jdlrobson moved this task from Incoming to FY2023-24 Q3 Sprint 5 on the Web-Team-Backlog board.Mar 4 2024, 6:31 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog.

Jdlrobson triaged this task as High priority.Mar 5 2024, 2:21 AM

ovasileva added a parent task: T354843: [Night mode] Make all open-by-default global navigation appear in night mode on mobile.Mar 7 2024, 6:38 PM

ovasileva set the point value for this task to 2.Mar 7 2024, 6:42 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.

Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 8 2024, 12:10 AM

bwang claimed this task.Mar 11 2024, 7:47 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.

bwang removed bwang as the assignee of this task.Mar 12 2024, 6:45 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.

bwang subscribed.

Change 1010605 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] Fix popups night mode

https://gerrit.wikimedia.org/r/1010605

gerritbot added a project: Patch-For-Review.Mar 12 2024, 6:58 PM

bwang claimed this task.Mar 12 2024, 7:33 PM

bwang moved this task from Code Review to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.Mar 13 2024, 6:23 PM

Jdlrobson reassigned this task from bwang to Edtadros.Mar 13 2024, 8:08 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.

Change 1010605 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix popups night mode

https://gerrit.wikimedia.org/r/1010605

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2024, 8:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 14 2024, 1:00 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Page previews should work in night mode.

screenshot 52.png (1×1 px, 479 KB)

Edtadros updated the task description. (Show Details)Mar 18 2024, 11:31 PM

Jdlrobson assigned this task to ovasileva.Mar 22 2024, 5:44 PM

Looks good but gradient is broken. Opened T360877: [Bug] Page previews gradient not working in night mode to track that. Resolving this one.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Page previews should work in night mode.

screenshot 127.png (849×1 px, 526 KB)

Edtadros updated the task description. (Show Details)Mar 26 2024, 10:15 PM

Edtadros mentioned this in T359679: Verify 1.42.0-wmf.23 deployment.Apr 3 2024, 9:55 PM

Jdlrobson closed subtask T360877: [Bug] Page previews gradient not working in night mode as Resolved.May 31 2024, 1:30 AM