Maniphest T366520

[Config] Dark mode is not available on Special:ApiSandbox
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

NOTE: This can be deployed as early as June 20th

Background

Dark mode is not available on Special:ApiSandbox. This task is about fixing the issues and enabling it.

User story

As a reader I want all pages to appear dark in dark mode.

Requirements

Fix color contrast issues on https://en.wikipedia.org/wiki/Special:ApiSandbox with page in dark mode
Fix color contrast issues on https://en.m.wikipedia.org/wiki/Special:ApiSandbox with page in dark mode
Enable via configuration change

BDD

For QA engineer to fill out

Test Steps

For QA engineer to fill out

Design

Add mockups and design requirements

Acceptance criteria

Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

Add communication criteria

Rollback plan

Revert the config change if unexpected issues arise.

This task was created by Version 1.0.0 of the Web team task template using phabulous

Details

Subject	Repo	Branch	Lines +/-
Enable dark mode on more pages	operations/mediawiki-config	master	+7 -18
Enable dark mode on more pages	operations/mediawiki-config	master	+9 -20
apisandbox, styles: Apply dark mode enabled color tokens	mediawiki/core	master	+3 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T366520 [Config] Dark mode is not available on Special:ApiSandbox
Resolved		Jdlrobson	T364777 [EPIC] Enable dark mode in OOUI
Declined	Feature	egardner	T363849 [OOUI] Make WikimediaUI theme compatible with CSS custom properties and future versions Codex Design Tokens
Duplicate		None	T364420 QA Editing-related night mode changes (desktop)
Open		ovasileva	T360691 QA Editing-related OOUI updates (mobile + desktop)
Duplicate	BUG REPORT	None	T365517 PopupWidget notification for hidden sidebars has white background
Declined	Feature	egardner	T363857 [OOUI] Make WikimediaUI theme compatible with 'rem' units and future versions Codex Design Tokens
Duplicate		CCiufo-WMF	T365521 QA Editing-related REM changes
Resolved		ovasileva	T365764 [OOUI] Icons: Add support for use in dark mode
Resolved		NBaca-WMF	T366709 [Spike] Make a decision on what needs to happen for icons before the new OOUI release
Declined		Volker_E	T366101 [OOUI] Fix font size inconsistencies across skins with `rem` based sizing

Event Timeline

Jdlrobson created this task.Jun 3 2024, 6:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2024, 6:54 PM

Jdlrobson renamed this task from [placeholder] Enable dark mode experiences for OOUI based pages to [placeholder] Enable dark mode experiences for OOUI based special pages.Jun 3 2024, 7:12 PM

Jdlrobson renamed this task from [placeholder] Enable dark mode experiences for OOUI based special pages to Enable dark mode experiences for OOUI based special pages.

Jdlrobson triaged this task as High priority.

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Jun 3 2024, 7:16 PM

Jdlrobson merged a task: T358408: Special:Block is not night mode ready (OOUI).

Jdlrobson added a subscriber: Masumrezarock100.

Jdlrobson renamed this task from Enable dark mode experiences for OOUI based special pages to Enable dark mode experiences for OOUI based special pages and actions.Jun 3 2024, 7:21 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subtask: T364777: [EPIC] Enable dark mode in OOUI.Jun 3 2024, 10:50 PM

Change #1042262 had a related patch set uploaded (by Jdlrobson; author: VolkerE):

[mediawiki/core@master] apisandbox, styles: Apply dark mode enabled color tokens

https://gerrit.wikimedia.org/r/1042262

gerritbot added a project: Patch-For-Review.Wed, Jun 12, 3:27 PM

Jdlrobson updated the task description. (Show Details)Thu, Jun 13, 12:16 AM

Jdlrobson updated the task description. (Show Details)Thu, Jun 13, 12:21 AM

@Jdlrobson I think it's better to merge this into T367095: OOUI dark mode bug fixes post-0.50.0 release

@Volker_E this was a pretty broader in scope - some things in those special pages are not using OOUI e.g. custom elements or Codex or other stuff which also need fixing.

It might make sense to split this out into 4 tasks for each of the special pages, now I think about it more...

Volker_E added a project: Design-System-Team.Thu, Jun 13, 3:25 PM

Volker_E moved this task from Inbox to Following on the Design-System-Team board.

Change #1042262 merged by jenkins-bot:

[mediawiki/core@master] apisandbox, styles: Apply dark mode enabled color tokens

https://gerrit.wikimedia.org/r/1042262

Maintenance_bot removed a project: Patch-For-Review.Thu, Jun 13, 6:31 PM

Volker_E updated the task description. (Show Details)Thu, Jun 13, 6:47 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Thu, Jun 13, 7:00 PM

Jdlrobson renamed this task from Enable dark mode experiences for OOUI based special pages and actions to Dark mode is not available on Special:ApiSandbox.Fri, Jun 14, 4:51 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from Dark mode is not available on Special:ApiSandbox to [Config] Dark mode is not available on Special:ApiSandbox.Fri, Jun 14, 4:54 PM

Jdlrobson lowered the priority of this task from High to Low.

Jdlrobson updated the task description. (Show Details)

Jdlrobson set the point value for this task to 1.

Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 6).

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs analysis to Blocked on Others on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.

Change #1042431 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable dark mode on more pages

https://gerrit.wikimedia.org/r/1042431

gerritbot added a project: Patch-For-Review.Fri, Jun 14, 4:55 PM

NBaca-WMF moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Thu, Jun 20, 4:56 PM

I'll enable this Monday.

Change #1041250 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable dark mode on more pages

https://gerrit.wikimedia.org/r/1041250

Change #1042431 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable dark mode on more pages

Reason:

Folded into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1041250

https://gerrit.wikimedia.org/r/1042431

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.Tue, Jun 25, 3:39 PM

Jdlrobson reassigned this task from Jdlrobson to KSarabia-WMF.Tue, Jun 25, 5:29 PM

Change #1041250 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable dark mode on more pages

https://gerrit.wikimedia.org/r/1041250

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:16:21Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]]

Stashbot mentioned this in T366373: [Config change] Enable night theme on pages which use data tables.Tue, Jun 25, 8:16 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:19:01Z] <cjming@deploy1002> jdlrobson, cjming: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-25T20:31:25Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1041250|Enable dark mode on more pages (T366378 T367374 T366373 T366520 T366373)]] (duration: 15m 04s)