Page MenuHomePhabricator

Dark mode: Special:Notifications
Closed, ResolvedPublic

Description

Background

The Web team is releasing dark mode more widely. To prepare for this, some Growth maintained features need improvements.

User story

  • As a user who uses dark mode, I want the ability to view my notifications in dark mode, so that I do not have an inconsistent experience

Echo - Special:Notifications
The issues are present only on Special:Notifications

DONE not visible elements
Screen Shot 2024-06-21 at 3.50.46 PM.png (1×2 px, 291 KB)
Fixed - checked on enwiki betalabs
Screen Shot 2024-07-11 at 12.44.44 PM.png (1×2 px, 417 KB)
DONE hovering over rows makes them unreadable
Screen Shot 2024-06-21 at 3.51.02 PM.png (1×2 px, 302 KB)
Fixed - checked on enwiki betalabs
Screen Shot 2024-07-11 at 12.47.41 PM.png (1×942 px, 258 KB)
DONE low contrast for oo-ui-image-invert
Screen Shot 2024-06-22 at 4.17.49 PM.png (1×2 px, 254 KB)
Fixed - checked on enwiki betalabs
Screen Shot 2024-07-11 at 12.48.36 PM.png (926×2 px, 269 KB)
Acceptance Criteria:

Given I'm viewing Special:Notifications
When I'm viewing in dark mode,
Then all elements are readable and pass WCAG AA contrast requirements

Event Timeline

KStoller-WMF moved this task from Inbox to Up Next on the Growth-Team board.

Also, when opening on of the popups that feature a new item it briefly flashes very light blue in dark mode.

Thank you, @Sjoerddebruin for reporting it! That change in color when a notifications changes from unseed state to the seen state, seems to be consistent with instances where such colors appear. For example, a success message (for a saved edit) displays the same color:

Screen Shot 2024-07-10 at 4.25.10 PM.png (318×972 px, 73 KB)

So, here is an animated gif for notifications displaying the same color when their state is changed (specifically the number four displays a green-blue color):

green_light_notifications.gif (888×1 px, 352 KB)

I don't seem to be able to reproduce any of the issues mentioned in the descriptions on enwiki's Special:Notifications (already on .wmf13). @Etonkovidova can you confirm?

I'm not able to reproduce the issue mentioned here in the comments either, but maybe I'm not understanding it well enough.

Etonkovidova updated the task description. (Show Details)

I don't seem to be able to reproduce any of the issues mentioned in the descriptions on enwiki's Special:Notifications (already on .wmf13). @Etonkovidova can you confirm?

I'm not able to reproduce the issue mentioned here in the comments either, but maybe I'm not understanding it well enough.

All issues reported in the task have been re-checked and marked as Done in the task description. I closed the task as Resolved.

Also, when opening on of the popups that feature a new item it briefly flashes very light blue in dark mode.

I now stumbled over a way to reproduce this and have created T370042: New Notification flashes bright blue, unreadable in dark mode for it.