Page MenuHomePhabricator

When both sidebars are open on Vector 2022, the Special:Notifications interface overlaps the right sidebar
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • On a wiki with Vector 2022 Zebra and Echo installed:
  • Receive notifications. The effect is more pronounced if you have 50 or more (of all time), as it causes a page button to appear.
  • Open [[Special:Notifications]] (don't forget ?VectorZebraDesign=1).

What happens?:

Notifications overflow into the right sidebar.

What should have happened instead?:

The boxes are reduced in width to fit on the page.

Other information (browser name/version, screenshots, etc.):

  • Resolution: 1366 x 768
  • Chrome OS
  • Unfortunately I cannot provide any more info because I can only reproduce this on a school-issued Chromebook that blocks the settings menu, including the about and version pages.

Screenshot 2023-06-01 12.26.25.png (658×1 px, 151 KB)

Requirement

Ensure that when both sidebars are open on Vector 2022, the Special:Notifications interface does not overlap the right sidebar by reducing the width of the notification boxes to fit within the available space.

BDD

gherkin
Feature: Prevent Overlap of Special:Notifications in Vector 2022

  Scenario: Special:Notifications interface does not overlap the right sidebar
    Given both sidebars are open in the Vector 2022 skin
    When the user opens Special:Notifications
    Then the notification boxes should be reduced in width to fit within the available space
    And there should be no overlap with the right sidebar

Test Steps

Test Case 1: Verify Special:Notifications Interface in Vector 2022

  1. Ensure both sidebars are open in the Vector 2022 skin.
  2. Navigate to Special:Notifications.
  3. AC1: Confirm that the notification boxes are reduced in width to fit within the available space.
  4. AC2: Confirm that there is no overlap with the right sidebar.

QA Results - Beta

ACStatusDetails
1T337954#9894559
2T337954#9894559

QA Results - Prod

ACStatusDetails
1T337954#9894562
2T337954#9894562

Event Timeline

This isn't specific to Zebra though ? Plain Vector 2022 does it as well for me.

This issue is due to the fact that the left and right sidebars will reduce the space of the content area when present. Rather than just relying on breakpoints, its probably worthwhile to check the main menu and page tools pinned feature classes (i.e. vector-feature-main-menu-pinned-enabled vector-feature-page-tools-pinned-disabled) to determine whether or not the sidebars are present

Jdlrobson renamed this task from Vector 2022 Zebra causes Special:Notifications to overlap the right sidebar to When both sidebars are open on Vector 2022, the Special:Notifications interface overlaps the right sidebar.Feb 8 2024, 5:22 PM
Jdlrobson removed bwang as the assignee of this task.
Jdlrobson added a subscriber: bwang.

This requires some changes in the Echo extension - some skin styles to limit the display of the Echo interface in this situation.

Change #1037177 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/Echo@master] Special:Notifications: Add additional wrapping

https://gerrit.wikimedia.org/r/1037177

Change #1040264 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/Echo@master] Allow sidebar to be slightly smaller

https://gerrit.wikimedia.org/r/1040264

Change #1037177 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Special:Notifications: Add additional wrapping

https://gerrit.wikimedia.org/r/1037177

Change #1040264 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Allow sidebar to be slightly smaller

https://gerrit.wikimedia.org/r/1040264

matmarex assigned this task to TheDJ.

Thanks for working on this! Tagging it with sprint 5 so it will get QAed.

Test Result - Beta

Status: ⬜ Could Not Test
Environment: Beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Special:Notifications Interface in Vector 2022

  1. Ensure both sidebars are open in the Vector 2022 skin.
  2. Navigate to Special:Notifications.
  3. AC1: Confirm that the notification boxes are reduced in width to fit within the available space.
  4. AC2: Confirm that there is no overlap with the right sidebar.

screenshot 2.mov.gif (824×1 px, 492 KB)

Edtadros added a project: Verified.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Special:Notifications Interface in Vector 2022

  1. Ensure both sidebars are open in the Vector 2022 skin.
  2. Navigate to Special:Notifications.
  3. AC1: Confirm that the notification boxes are reduced in width to fit within the available space.
  4. AC2: Confirm that there is no overlap with the right sidebar.

screenshot 3.mov.gif (784×2 px, 3 MB)