Module talk:Message box
This module was considered for deletion on 2020 February 15. The result of the discussion was "keep". |
Module:Message box is permanently protected from editing because it is a heavily used or highly visible module. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit protected}} to notify an administrator to make the requested edit.
|
|
|
This page has archives. Sections older than 30 days may be automatically archived by Lowercase sigmabot III when more than 4 sections are present. |
Edit request 8 May 2024
This edit request to Module:Message box/ombox.css has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Description of suggested change: Add CSS styling for night mode to the ombox styles.css. Diff:
− | .ombox {
margin: 4px 0;
border-collapse: collapse;
border: 1px solid #a2a9b1; /* Default "notice" gray */
background-color: #f8f9fa;
box-sizing: border-box; | + | .ombox {
margin: 4px 0; border-collapse: collapse; border: 1px solid #a2a9b1; /* Default "notice" gray */ background-color: #f8f9fa; box-sizing: border-box; } html.skin-theme-clientpref-night .ombox { margin: 4px 0; border-collapse: collapse; border: 1px solid #f8f9fa; /* Off-white */ background-color: #00143d; /* Dark blue */ box-sizing: border-box; } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox { margin: 4px 0; border-collapse: collapse; border: 1px solid #f8f9fa; /* Off-white */ background-color: #00143d; /* Dark blue */ box-sizing: border-box; } } /* For the "small=yes" option. */ .ombox.mbox-small { font-size: 88%; line-height: 1.25em; } .ombox-speedy { border: 2px solid #b32424; /* Red */ background-color: #fee7e6; /* Pink */ } html.skin-theme-clientpref-night .ombox-speedy { border: 2px solid #ffdbdb; /* Light pink */ background-color: #b32424; /* Red */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-speedy { border: 2px solid #ffdbdb; /* Light pink */ background-color: #b32424; /* Red */ } } .ombox-delete { border: 2px solid #b32424; /* Red */ } html.skin-theme-clientpref-night .ombox-delete { border: 2px solid #ff6961; /* Pink */ background-color: #b32424; /* Red */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-delete { border: 2px solid #ff6961; /* Pink */ background-color: #b32424; /* Red */ } } .ombox-content { border: 1px solid #f28500; /* Orange */ } html.skin-theme-clientpref-night .ombox-content { border: 1px solid #ffe7ce; /* Off-white */ background-color: #ff8f05; /* Orange */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-content { border: 1px solid #ffe7ce; /* Off-white */ background-color: #ff8f05; /* Orange */ } } .ombox-style { border: 1px solid #fc3; /* Yellow */ } html.skin-theme-clientpref-night .ombox-style { border: 1px solid #fff9db; /* Off-white */ background-color: #fad000; /* Yellow */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-style { border: 1px solid #fff9db; /* Off-white */ background-color: #fad000; /* Yellow */ } } .ombox-move { border: 1px solid #9932cc; /* Purple */ } html.skin-theme-clientpref-night .ombox-move { border: 1px solid #c9b3ff; /* Light purple */ background-color: #7500db; /* Purple */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-move { border: 1px solid #c9b3ff; /* Light purple */ background-color: #7500db; /* Purple */ } } .ombox-protection { border: 2px solid #a2a9b1; /* Gray-gold */ } html.skin-theme-clientpref-night .ombox-protection { border: 1px solid #fff; /* White */ background-color: #a2a9b1; /* Blueish-light gray */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-protection { border: 1px solid #fff; /* White */ background-color: #a2a9b1; /* Blueish-light gray */ } } |
Andumé (talk) 23:45, 8 May 2024 (UTC)
- Another option with a darker/higher contrast/more consistent color scheme would be this:
− | .ombox {
margin: 4px 0; border-collapse: collapse; border: 1px solid #a2a9b1; /* Default "notice" gray */ background-color: #f8f9fa; box-sizing: border-box; | + | .ombox {
margin: 4px 0; border-collapse: collapse; border: 1px solid #a2a9b1; /* Default "notice" gray */ background-color: #f8f9fa; box-sizing: border-box; } html.skin-theme-clientpref-night .ombox { margin: 4px 0; border-collapse: collapse; border: 1px solid #f8f9fa; /* Off-white */ background-color: #00143d; /* Dark blue */ box-sizing: border-box; } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox { margin: 4px 0; border-collapse: collapse; border: 1px solid #f8f9fa; /* Off-white */ background-color: #00143d; /* Dark blue */ box-sizing: border-box; } } /* For the "small=yes" option. */ .ombox.mbox-small { font-size: 88%; line-height: 1.25em; } .ombox-speedy { border: 2px solid #b32424; /* Red */ background-color: #fee7e6; /* Pink */ } html.skin-theme-clientpref-night .ombox-speedy { border: 2px solid #ffdbdb; /* Light pink */ background-color: #571818; /* Dark red */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-speedy { border: 2px solid #ffdbdb; /* Light pink */ background-color: #571818; /* Dark red */ } } .ombox-delete { border: 2px solid #b32424; /* Red */ } html.skin-theme-clientpref-night .ombox-delete { border: 2px solid #ff6961; /* Pink */ background-color: #571818; /* Dark red */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-delete { border: 2px solid #ff6961; /* Pink */ background-color: #571818; /* Dark red */ } } .ombox-content { border: 1px solid #f28500; /* Orange */ } html.skin-theme-clientpref-night .ombox-content { border: 1px solid #ffe7ce; /* Off-white */ background-color: #955200; /* Dark orange */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-content { border: 1px solid #ffe7ce; /* Off-white */ background-color: #955200; /* Dark orange */ } } .ombox-style { border: 1px solid #fc3; /* Yellow */ } html.skin-theme-clientpref-night .ombox-style { border: 1px solid #fff9db; /* Off-white */ background-color: #9d7900; /* Dark yellow */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-style { border: 1px solid #fff9db; /* Off-white */ background-color: #9d7900; /* Dark yellow */ } } .ombox-move { border: 1px solid #9932cc; /* Purple */ } html.skin-theme-clientpref-night .ombox-move { border: 1px solid #c9b3ff; /* Light purple */ background-color: #2d0055; /* Dark purple */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-move { border: 1px solid #c9b3ff; /* Light purple */ background-color: #2d0055; /* Dark purple */ } } .ombox-protection { border: 2px solid #a2a9b1; /* Blue-gray */ } html.skin-theme-clientpref-night .ombox-protection { border: 1px solid #fff; /* White */ background-color: #3b3d40; /* Blueish-dark gray */ } @media (prefers-color-scheme: dark) { html.skin-theme-clientpref-night .ombox-protection { border: 1px solid #fff; /* White */ background-color: #3b3d40; /* Blueish-dark gray */ } } |
- Andumé (talk) 17:37, 11 May 2024 (UTC)
Not done: These diffs introduce duplicate styles and more color styles than are necessary to deal with the issue of dark mode. Thanks for throwing something up though, I will take a look. Izno (talk) 04:06, 21 May 2024 (UTC)
- @I Am Andumé For the first, you copy-pasted the full .ombox definition in the context of the color CSS, which is surely not intended. For the second, you typoed the prefers-color-scheme dark selector (it should be -os, not -night), made multiple separate blocks for the prefers-color scheme (perhaps to show that you were consistent between -dark and -os settings, IDK), and more concerningly you strayed to changing the background rather than changing just the border. We should do something which matches the earlier rules in what is being set, which for most of these cases is just the border. Izno (talk) 04:22, 21 May 2024 (UTC)
- Actually taking a look what happens when the background is dark, I don't think we need to change the border colors at all and can leave those the same as the base colors. That simplifies maintenance tremendously. We need to pick a good dark color for the typical background, as well as the speedy color. Izno (talk) 04:37, 21 May 2024 (UTC)
- I put those in the official sandbox and loaded that so now you can see them on Template:Ombox/testcases#name=_text=text. Izno (talk) 04:55, 21 May 2024 (UTC)
- @Izno:
- Thanks for taking a look at my request. Here are a few things I'd like to mention:
- The reason I copy-pasted the full .ombox definition, instead of just the styling that needed to be different in night mode was because I was afraid the other CSS would not be applied to the night mode version of the template if I omitted it.
- That was a typo, yes.
- I made separate block for the prefers-color-scheme as I was not yet aware it was possible to combine it all into one.
- Changing the background color was necessary as otherwise it would have been very bright (as you seem to have noticed). Also, without either defining color or changing background color, the text would not have been readable.
- Anyways, I wrote this CSS quite a while ago, so I was very inexperienced at the time, which explains a lot of the mistakes I made. Andumé (talk) 05:07, 21 May 2024 (UTC)
- No worries. Yes, it was necessary to change the background, but only for the broad .ombox and for the more narrow .ombox-speedy. You included background colors elsewhere. Which can reasonably be explained by your inexperience with CSS as you explained. Izno (talk) 05:16, 21 May 2024 (UTC)
- @Izno: iirc, the addition of the other background colors was also because I first worked on the cmbox CSS, and then reused much of the styling for ombox. Andumé (talk) 05:36, 21 May 2024 (UTC)
- That would explain the blue! Izno (talk) 05:54, 21 May 2024 (UTC)
- @Izno: iirc, the addition of the other background colors was also because I first worked on the cmbox CSS, and then reused much of the styling for ombox. Andumé (talk) 05:36, 21 May 2024 (UTC)
- No worries. Yes, it was necessary to change the background, but only for the broad .ombox and for the more narrow .ombox-speedy. You included background colors elsewhere. Which can reasonably be explained by your inexperience with CSS as you explained. Izno (talk) 05:16, 21 May 2024 (UTC)
- Actually taking a look what happens when the background is dark, I don't think we need to change the border colors at all and can leave those the same as the base colors. That simplifies maintenance tremendously. We need to pick a good dark color for the typical background, as well as the speedy color. Izno (talk) 04:37, 21 May 2024 (UTC)
- @I Am Andumé For the first, you copy-pasted the full .ombox definition in the context of the color CSS, which is surely not intended. For the second, you typoed the prefers-color-scheme dark selector (it should be -os, not -night), made multiple separate blocks for the prefers-color scheme (perhaps to show that you were consistent between -dark and -os settings, IDK), and more concerningly you strayed to changing the background rather than changing just the border. We should do something which matches the earlier rules in what is being set, which for most of these cases is just the border. Izno (talk) 04:22, 21 May 2024 (UTC)
Protected edit request on 14 June 2024
This edit request to Module:Message box/ombox.css has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please add:
/** T367463 */
body.skin--responsive table.ombox img {
max-width: none !important;
}
to Module:Message box/ombox.css as a workaround for phab:T367463, similar to {{tmbox}}'s Special:Diff/1228936760. I've applied the change to the sandbox (Special:Diff/1228972046/1229011205), but looking at testcases won't be helpful, because the sandbox template styles affect both live and sandbox versions of the template. Instead, compare Template:Wikibreak/testcases (uses live template styles as of Special:Diff/1229011841) and Template:Sockpuppet/testcases (uses sandbox styles as of Special:Diff/1229011265). See also Wikipedia:Village pump (technical)#Ombox images sometimes not showing. —andrybak (talk) 10:41, 14 June 2024 (UTC)
- Ping for awareness: User:Jon (WMF). —andrybak (talk) 13:08, 14 June 2024 (UTC)
Done — Preceding unsigned comment added by Jon (WMF) (talk • contribs) 15:59, 14 June 2024 (UTC)
Protected edit request on 25 June 2024
It is requested that an edit be made to the fully protected module at Module:Message box/fmbox.css. (edit · history · last · links · transclusion count · protection log) This template must be followed by a complete and specific description of the request, so that an editor unfamiliar with the subject matter could complete the requested edit immediately.
Edit requests to fully protected pages should only be used for edits that are either uncontroversial or supported by consensus. If the proposed edit might be controversial, discuss it on the protected page's talk page before using this template. To request that a page be protected or unprotected, make a protection request. When the request has been completed or denied, please add the |
Change fmbox-warning background-color to #300 in night mode for consistency with other mboxes.
Diff:
− | html.skin-theme-clientpref-night .fmbox-warning {
background-color: | + | html.skin-theme-clientpref-night .fmbox-warning {
background-color: #300; /* Reddish, same hue/saturation as light */
}
@media (prefers-color-scheme: dark) {
html.skin-theme-clientpref-os .fmbox-warning {
background-color: #300; /* Reddish, same hue/saturation as light */
}
}
|
Andumé (talk) 04:52, 25 June 2024 (UTC)
- No opinion on the change request, but presumably if you want to change the bg color, then you'd want to change the comment to match? Mathglot (talk) 18:09, 25 June 2024 (UTC)
- That would probably be a good idea, although those comments are often inaccurate anyway, especially on Module:Message box/cmbox.css. Andumé (talk) 21:30, 25 June 2024 (UTC)
- Shouldn't be inaccurate? The only one I can think of is the blue of one of the specific cmboxes. IznoPublic (talk) 06:48, 8 July 2024 (UTC)
- @Izno: The specific inaccuracy I was thinking of was the cmbox.css's night mode styles refer to #300 as "pink", although that is not the only one. Andumé (talk) 20:29, 14 July 2024 (UTC)
- And in fact cmbox makes no claim about similar hue/saturation that I can see?? Please ensure you're being factual. IznoPublic (talk) 06:50, 8 July 2024 (UTC)
- Shouldn't be inaccurate? The only one I can think of is the blue of one of the specific cmboxes. IznoPublic (talk) 06:48, 8 July 2024 (UTC)
- That would probably be a good idea, although those comments are often inaccurate anyway, especially on Module:Message box/cmbox.css. Andumé (talk) 21:30, 25 June 2024 (UTC)
- The light colors are also not consistent IIRC? Which specific other dark box are you trying to make this consistent with and what is the light color for that box? IznoPublic (talk) 06:48, 8 July 2024 (UTC)
- What I meant with "consistency" was that cmbox's night mode styles (cmbox being the only standard mbox to use colorful backgrounds afaik), for colored backgrounds, use the same background color as the light mode styles, except with a lightness of 10. Also, cmbox-delete and cmbox-speedy both have the same background in light mode as fmbox-warning, and they use #300 as background-color in night mode. I hope this makes sense. Andumé (talk) 20:41, 14 July 2024 (UTC)
Edit request 28 June 2024
This edit request to Module:Message box/fmbox.css has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Description of suggested change: I propose changing transparent to #FFFFFF (white) on Module:Message box/fmbox.css because some edit filters use white backgrounds for friendly or standard warning messages. If transparent was used here, then it would not appear white, rather light-red seeping thorough the warning message (this shows a warning box covering the edit filter warning or disallow message). The same also goes for disallow messages that use | friendly = yes
.
Diff:
− | .fmbox-editnotice {
background-color: | + | .fmbox-editnotice {
background-color: #FFFFFF; /* White */
} |
Anybody can comment about the proposed change I suggested, thank you. Codename Noreste 🤔 Talk 19:10, 28 June 2024 (UTC)
- Two things: fmbox should not be embedded in other (fm)boxes, making this change unnecessary here, and any change along this dimension should be sensitive to dark mode, and that isn't. IznoPublic (talk) 12:47, 8 July 2024 (UTC)