Jump to content

Template talk:Closed request top: Difference between revisions

From Meta, a Wikimedia project coordination wiki
Latest comment: 9 years ago by Sj in topic Proposal to update code
Content deleted Content added
No edit summary
No edit summary
Line 2: Line 2:


Hi. I have designed a new template code for this. You can review it at [[User:MarcoAurelio/Sandbox]] ([https://meta.wikimedia.org/wiki/User:MarcoAurelio/Sandbox?action=raw raw code]). It adds a tally, automatic calculation of support percent and automatic categorization based on the base page name, and an optional "result" field for you to fill with "promoted"/"no consensus" and your signature, that if empty is hidden. I'd love to hear your opinions on changing the template code to this one. Further, I'd also create a {{tlx|closed request bottom}} and move this one to {{tlx|closed request top}} with redirect to this page, so you don't have to remember the page move. Ping bureaucrats: {{ping|Barras|M7|MF-Warburg|Matanya|Mentifisto|Sj|Thehelpfulone|Tiptoety}} and template experts {{ping|Patrick|Pathoschild}}. Best regards. —[[User:MarcoAurelio|MarcoAurelio]] 13:45, 8 August 2015 (UTC)
Hi. I have designed a new template code for this. You can review it at [[User:MarcoAurelio/Sandbox]] ([https://meta.wikimedia.org/wiki/User:MarcoAurelio/Sandbox?action=raw raw code]). It adds a tally, automatic calculation of support percent and automatic categorization based on the base page name, and an optional "result" field for you to fill with "promoted"/"no consensus" and your signature, that if empty is hidden. I'd love to hear your opinions on changing the template code to this one. Further, I'd also create a {{tlx|closed request bottom}} and move this one to {{tlx|closed request top}} with redirect to this page, so you don't have to remember the page move. Ping bureaucrats: {{ping|Barras|M7|MF-Warburg|Matanya|Mentifisto|Sj|Thehelpfulone|Tiptoety}} and template experts {{ping|Patrick|Pathoschild}}. Best regards. —[[User:MarcoAurelio|MarcoAurelio]] 13:45, 8 August 2015 (UTC)

: Hi Marco, I like this model, as long as the tally is not required and can be turned off. <span style="background-color:white;color:#bbb;">&ndash;[[User:Sj|SJ]]<small>&nbsp;[[User Talk:Sj|<font style="color:#f90;">talk</font>]]&nbsp;</small></span> 03:45, 19 August 2015 (UTC)
:When I close requests I don't add the tally usually and I never would do that on the top of the page. I just make a horizontal line and add the result below. However, I like the automatic categorization. -[[User:Barras|<span style="color:blue; font-family:Bookman Old Style">'''Barras'''</span>]] [[User Talk:Barras|<span style="color:red; font-family:Bookman Old Style">'''talk'''</span>]] 17:14, 8 August 2015 (UTC)

:: The code looks fine to me. I made the tally optional, but feel free to revert if you don't want that:
:: {| class="wikitable" valign="middle"
|-
| <pre>{{closed request|7|2|0}}</pre>
| →
| <div style="background:#F5FFF5; margin:2em 0 0 0; padding:0 10px; border:1px solid #AAA;">
:''The following discussion is preserved as an archive of a closed Meta-Wiki [[:Category:Meta-Wiki requests|request]]. <strong style="color:red">Please do not modify it.</strong>
:: Final tally: [[File:Symbol support vote.svg|15px|Support]] '''Support''': 7 • [[File:Symbol oppose vote.svg|15px|Oppose]]&nbsp;<b>Oppose</b>: 2 • [[File:Symbol neutral vote.svg|15px|Neutral]] '''Neutral''': 0 (77.78%)
----
|-
| <pre>{{closed request}}</pre>
| →
| <div style="background:#F5FFF5; margin:2em 0 0 0; padding:0 10px; border:1px solid #AAA;">
:''The following discussion is preserved as an archive of a closed Meta-Wiki [[:Category:Meta-Wiki requests|request]]. <strong style="color:red">Please do not modify it.</strong>
----
|}
:: —<small>[[User talk:Pathoschild/s|Pathoschild]] 17:43, 08 August 2015 (UTC)</small>

::: Thank you {{u|Pathoschild}}. I also like that the tally be optional for people like {{u|Barras}} who prefers to add the result at the end. Thanks for the code review and tweaks. Best regards. &mdash;[[User:MarcoAurelio|MarcoAurelio]] 18:35, 8 August 2015 (UTC)
:::: Hi Marco - I like this model, as long as the tally is optional. <span style="background-color:white;color:#bbb;">&ndash;[[User:Sj|SJ]]<small>&nbsp;[[User Talk:Sj|<font style="color:#f90;">talk</font>]]&nbsp;</small></span> 03:45, 19 August 2015 (UTC)

:I don't know if I understand it correctly. Will the templates {{tlx|closed request bottom}} and {{tlx|closed request top}} just contain the code which we already (sometimes) use in order to create this "This request is closed" box around a request? If yes, I dont think it's controversial to create them. --<small>[[User:MF-Warburg|MF-W]]</small> 22:14, 8 August 2015 (UTC)
:: {{ping|MF-Warburg}} Yes, the template appearance will not be changing. It just will let the closing bureaucrat to optionally add a tally and a result (if not, they won't show), and will automatically categorize the requestpage on the relevant category. &mdash;[[User:MarcoAurelio|Marco]][[User talk:MarcoAurelio|Aurelio]] 11:13, 10 August 2015 (UTC)

Revision as of 03:46, 19 August 2015

Proposal to update code

Hi. I have designed a new template code for this. You can review it at User:MarcoAurelio/Sandbox (raw code). It adds a tally, automatic calculation of support percent and automatic categorization based on the base page name, and an optional "result" field for you to fill with "promoted"/"no consensus" and your signature, that if empty is hidden. I'd love to hear your opinions on changing the template code to this one. Further, I'd also create a {{closed request bottom}} and move this one to {{closed request top}} with redirect to this page, so you don't have to remember the page move. Ping bureaucrats: @Barras, M7, MF-Warburg, Matanya, Mentifisto, Sj, Thehelpfulone, and Tiptoety: and template experts @Patrick and Pathoschild:. Best regards. —MarcoAurelio 13:45, 8 August 2015 (UTC)Reply

When I close requests I don't add the tally usually and I never would do that on the top of the page. I just make a horizontal line and add the result below. However, I like the automatic categorization. -Barras talk 17:14, 8 August 2015 (UTC)Reply
The code looks fine to me. I made the tally optional, but feel free to revert if you don't want that:
{{closed request|7|2|0}}
The following discussion is preserved as an archive of a closed Meta-Wiki request. Please do not modify it.
Final tally: Support Support: 7 • Oppose Oppose: 2 • Neutral Neutral: 0 (77.78%)

{{closed request}}
The following discussion is preserved as an archive of a closed Meta-Wiki request. Please do not modify it.

Pathoschild 17:43, 08 August 2015 (UTC)
Thank you Pathoschild. I also like that the tally be optional for people like Barras who prefers to add the result at the end. Thanks for the code review and tweaks. Best regards. —MarcoAurelio 18:35, 8 August 2015 (UTC)Reply
Hi Marco - I like this model, as long as the tally is optional. SJ talk  03:45, 19 August 2015 (UTC)Reply
I don't know if I understand it correctly. Will the templates {{closed request bottom}} and {{closed request top}} just contain the code which we already (sometimes) use in order to create this "This request is closed" box around a request? If yes, I dont think it's controversial to create them. --MF-W 22:14, 8 August 2015 (UTC)Reply
@MF-Warburg: Yes, the template appearance will not be changing. It just will let the closing bureaucrat to optionally add a tally and a result (if not, they won't show), and will automatically categorize the requestpage on the relevant category. —MarcoAurelio 11:13, 10 August 2015 (UTC)Reply