etc
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• brooke
	May 19 2017, 8:01 AM

Description

With the MP3 patents expired and (hopefully) everything legally clear, T115170 is adding MP3 upload/ingest/playback support. It'd be nice to additionally transcode other audio files *to* MP3 for playback in Safari/IE/Edge which currently require the ogv.js JavaScript shim. (ogv.js is awesome but is a large chunk of JS, even just for Ogg Vorbis audio, and it'd be nice to avoid loading it.)

May require legal's sign-off for production, but likely clear if everything's cleared on T115170 and friends.

This should not be too difficult, as can use ffmpeg for the actual transcoding.

Details

	Subject	Repo	Branch	Lines +/-
	Desktop native MP3 at higher priority than ogv.js Ogg	mediawiki/extensions/TimedMediaHandler	master	+2 -2
	Enable MP3 audio transcodes by default	mediawiki/extensions/TimedMediaHandler	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T115170: Add support for MP3

Event Timeline

• brooke created this task.May 19 2017, 8:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2017, 8:01 AM

El_Grafo subscribed.Jul 18 2017, 3:03 PM

@CKoerner_WMF do we think there's a need for a discussion on this one? I'd like to go ahead with MP3 output for audio, particularly to resolve the issue of audio playback on iOS (where the TimedMediaHandler fancy player still doesn't work, and the ogv.js shim would load slowly even if we added it).

I can prepare a sample announcement/discussion prompt page...

Have made a draft proposal here: https://commons.wikimedia.org/wiki/User:Brion_Vibber_(WMF)/MP3_output_discussion

greg subscribed.Aug 11 2017, 7:06 PM

I don't see any issue with that.

Brion, I think you should post your draft. Thank you for adding a mention to keep the two conversation about MP3s separate!

Change 380791 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Enable MP3 audio transcodes by default

https://gerrit.wikimedia.org/r/380791

gerritbot added a project: Patch-For-Review.Sep 26 2017, 5:17 PM

Got back to this finally. :) Posted at https://commons.wikimedia.org/wiki/Commons:Village_pump#Adding_MP3_audio_output_for_iOS_compatibility

Patch to flip the default to add MP3 is ready, but I notice that on desktop ogv.js continues to have higher priority. Will have to fiddle with that, but main goal is to get iOS working which it does.

Ainali subscribed.Sep 26 2017, 5:23 PM

zhuyifei1999 subscribed.Sep 26 2017, 7:12 PM

Raymond awarded a token.Sep 27 2017, 10:35 AM

Raymond subscribed.

gh87 added projects: Browser-Support-Internet-Explorer, Browser-Support-Microsoft-Edge, Browser-Support-Apple-Safari.Nov 14 2017, 1:16 AM

Change 380791 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Enable MP3 audio transcodes by default

https://gerrit.wikimedia.org/r/380791

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 28 2017, 1:00 AM

Leaving open for the desktop priority issue – merged patch "only" gets iOS working.

Change 393941 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Desktop native MP3 at higher priority than ogv.js Ogg

https://gerrit.wikimedia.org/r/393941

gerritbot added a project: Patch-For-Review.Nov 28 2017, 11:32 PM

Jdforrester-WMF closed this task as Resolved.Nov 29 2017, 1:15 AM

Jdforrester-WMF assigned this task to • brooke.

Jdforrester-WMF removed a project: Patch-For-Review.

Change 393941 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Desktop native MP3 at higher priority than ogv.js Ogg