Page MenuHomePhabricator
Create Task
Maniphest T192273

Special:WikiSets should use CSS instead of deprecated width attribute
Closed, ResolvedPublic
Actions

Description

According to Nu Html Checker, pages such as
https://meta.wikimedia.org/wiki/Special:WikiSets/2
use deprecated HTML attribute "width". This comes from
https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/608dc6e7521ed930dd976b55fc53bcf0d302775f/includes/specials/SpecialWikiSets.php#L216-L273

Details

SubjectRepoBranchLines +/-
Replace deprecated HTML 'width' function, use CSS insteadmediawiki/extensions/CentralAuthmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

He7d3r created this task.Apr 16 2018, 12:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 16 2018, 12:16 PM
He7d3r updated the task description. (Show Details)Apr 16 2018, 12:19 PM
He7d3r added a parent task: T2209: [DO NOT USE] HTML validity (tracking).
MarcoAurelio added subscribers: Jayprakash12345, MarcoAurelio.Apr 16 2018, 3:45 PM

Maybe we can take this oportunity to covert the page to OOUI. @Jayprakash12345 what do you think? Thanks.

Krinkle removed a parent task: T2209: [DO NOT USE] HTML validity (tracking).Apr 20 2018, 4:14 PM
Jayprakash12345 added a comment.Apr 20 2018, 6:21 PM

@Jayprakash12345 what do you think? Thanks.

Special pages which use table tag is hard to convert into OOUI and takes a lot of time in review. (i.e. T117884) Even some easy conversion of Centralauth is 424373 is taking time. So I think this will bad idea to depend on OOUI conversion for this task. Also OOUI conversion for Extension:Centralauth (T104298) is a bit like stalling :)

MarcoAurelio claimed this task.Apr 20 2018, 7:08 PM

Thanks for the info @Jayprakash12345 - I'll try to fix this via CSS then.

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptApr 20 2018, 7:08 PM
MarcoAurelio moved this task from unsorted/backlog to working on on the User-MarcoAurelio board.Apr 20 2018, 7:08 PM
gerritbot subscribed.Apr 20 2018, 9:43 PM

Change 428022 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/CentralAuth@master] [WIP] Replace deprecated HTML 'width' function, use CSS instead

https://gerrit.wikimedia.org/r/428022

gerritbot added a project: Patch-For-Review.Apr 20 2018, 9:43 PM
MarcoAurelio moved this task from working on to ready/patched/SWAT on the User-MarcoAurelio board.Apr 21 2018, 8:13 AM
MarcoAurelio triaged this task as Medium priority.Apr 21 2018, 11:26 AM
gerritbot added a comment.Apr 26 2018, 10:03 PM

Change 428022 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Replace deprecated HTML 'width' function, use CSS instead

https://gerrit.wikimedia.org/r/428022

MarcoAurelio closed this task as Resolved.Apr 26 2018, 10:04 PM
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.
MarcoAurelio removed a project: Patch-For-Review.
MarcoAurelio moved this task from ready/patched/SWAT to cabinet on the User-MarcoAurelio board.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 26 2018, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits