That, or fix links https://www.mediawiki.org/w/index.php?title=Special:LinkSearch&target=svn.wikimedia.org

Just fixed another one of these (edit). Looks like there are many more broken urls on mediawiki.org wiki pages,
https://www.mediawiki.org/w/index.php?title=Special:LinkSearch&limit=250&offset=0&target=http%3A%2F%2Fsvn.wikimedia.org%2Fdoc%2F

Probably many more broken urls on other wikis, in commit messages, other websites, and perhaps in less mutable publications/archivings.

I've asked about this on IRC. It seems to only take a 1 line change in Puppet to fix the redirect. But in 2013 when this task was filed there seems to have been some confusion about how override works. If this is still an issue, one may want to reach out via Scrum of Scrums that you are blocked on SRE to answer that concern.

Perhaps simplest to submit the change as written and handle the details in code review instead.

Untagging Platform Engineering, since there is currently no work for the team to do on this.

Current status

svn.wikimedia.org/ redirects to https://phabricator.wikimedia.org/diffusion/
svn.wikimedia.org/doc/ redirects to https://doc.wikimedia.org/mediawiki-core/master/php/

The redirects are so like described in the task.

Proposal plan

The example given /doc/classWikiPage.html is rather trivial to fix, as the filenames didn't change:

https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html

So I guess the best plan is to redirect svn.wikimedia.org/doc(/.*) to https://doc.wikimedia.org/mediawiki-core/master/php$1

(and address during code review any override issue, if any, per Krinkle comment)

Actually, you can use the compiler of redirect.dat as a software to output to stdout the result:

ruby modules/mediawiki/lib/puppet/parser/functions/compile_redirects.rb modules/mediawiki/files/apache/sites/redirects/redirects.dat

Also, this language has rules to avoid to write and maintain regexp for trivial cases, like redirect a whole domain.

The current rules don't allow the more complex redirection where a PART of the original URL has to been taken.

The easiest is to provide more flexibility and allow to directly pass Apache/nginx regexp in redirects.dat for more complex cases.

I'm submitting a path with this approach, it provides the following redirect:

# regexp        svn.wikimedia.org/doc(/.*)      https://doc.wikimedia.org/mediawiki-core/master/php$1
RewriteCond %{HTTP_HOST} =svn.wikimedia.org
RewriteRule ^/doc(/.*)$ https://doc.wikimedia.org/mediawiki-core/master/php$1 [R=301,L,NE]

Change 631888 had a related patch set uploaded (by Dereckson; owner: Dereckson):
[operations/puppet@production] Redirect svn.wikimedia.org/doc properly

https://gerrit.wikimedia.org/r/631888

Ping - how to get a review from SRE on this patch? (@Vgutierrez was mentioned in https://gerrit.wikimedia.org/r/c/operations/puppet/+/631888/ ?)

@Aklapper asked the same on Gerrit, it seems to me this is serviceops rather than traffic because it's an appserver change and mediawiki module.

Could someone review https://gerrit.wikimedia.org/r/c/operations/puppet/+/631888

Who are the ones responsible for this review?

In T109950#9175846, @Dereckson wrote:

Who are the ones responsible for this review?

I would expect https://phabricator.wikimedia.org/project/members/3775/

This is still blocked on https://gerrit.wikimedia.org/r/c/operations/puppet/+/631888. It's probably fair to assume the volunteer gave up.

I think more went inactive generally than gave up on this specific issue. But still, we really need to do better here.