Page MenuHomePhabricator

Gerrit project search result do not paginate correctly
Closed, ResolvedPublicBUG REPORT

Description

Upstream https://bugs.chromium.org/p/gerrit/issues/detail?id=15156


List of steps to reproduce (step by step, including full links if applicable):

  • Search for "skins" on Gerrit like this: https://gerrit.wikimedia.org/r/admin/repos/q/filter:skins
  • Note that the list ends at "mediawiki/skins/GreyStuff" and doesn't include any of the skins whose names would be alphabetically sorted later (e.g. Vector)
  • Also note that on the lower-right side of the page the word "Page 1" appears and no pagination links exist to get you to page 2

What happens?:
Somehow, Gerrit fails to provide access to all search results and only shows the first page of results without any pagination links.

What should have happened instead?:
The bottom-right side of the page should include links to subsequent search results.

Implications
An inexperienced user who is trying to install MediaWiki for the first time will notice that Vector skin is missing. The user will likely follow the MediaWiki.org documentation to get to https://www.mediawiki.org/wiki/Download_from_Git#Using_Git_to_download_MediaWiki_skins where there is a link to "List of skins in git" which links to https://gerrit.wikimedia.org/r/admin/repos/q/filter:mediawiki+skins and that link does *not* lead the user to Vector's git URL. The user may not find the way to install Vector from Git.

Software version
Gerrit 3.3.6

image.png (139×768 px, 6 KB)

Event Timeline

hashar renamed this task from Gerrit's search result do not paginate correctly to Gerrit project search result do not paginate correctly.Oct 11 2021, 8:48 AM
hashar updated the task description. (Show Details)

I went to https://gerrit.wikimedia.org/r/admin/repos and filed skins. The web interface does an API requests to https://gerrit.wikimedia.org/r/projects/?n=26&S=0&query=skins which is described at https://gerrit.wikimedia.org/r/Documentation/rest-api-projects.html

ParameterValueDescription
n26Limit number of projects returned
S0Skip the given number of projects from the beginning of the list.
queryskinsA search query ( https://gerrit.wikimedia.org/r/Documentation/user-search-projects.html )

And indeed the API call returns 26 projects without any indication of paging.

The same issue appears on Google instance searching for plugins (3.4.1-2332-gd90324276f) https://gerrit-review.googlesource.com/admin/repos/q/filter:plugins

hashar triaged this task as Medium priority.Oct 11 2021, 9:14 AM
hashar updated the task description. (Show Details)
hashar moved this task from Backlog to Reported Upstream on the Upstream board.
Paladox subscribed.

Seems this is fixed as the next button is shown for me.