Page MenuHomePhabricator

Canary deployment continuation prompt should emit a timestamp to console
Closed, ResolvedPublic

Description

I'd like an easy way to know when the canary node's deployed services were successfully promoted, to help with cross-checking error logs. Currently, the console reads:

17:20:10 Started deploy [ores/deploy@1712122]
17:20:10 Deploying Rev: HEAD = 171212271e77db220c022d416c6b7adefefc4d9d
17:20:11 Started deploy [ores/deploy@1712122]: fawiki wp10; ORES update: T201518
17:20:11 
== CANARY ==
:* ores1001.eqiad.wmnet
ores/deploy: fetch stage(s): 100% (ok: 1; fail: 0; left: 0)                     
ores/deploy: config_deploy stage(s): 100% (ok: 1; fail: 0; left: 0)             
ores/deploy: promote and restart_service stage(s): 100% (ok: 1; fail: 0; left: 0)
canary deploy successful. Continue? [y]es/[n]o/[c]ontinue all groups:

I'm thinking that the last two lines should be replaced by:

17:41:23 canary deploy successful.
Continue? [y]es/[n]o/[c]ontinue all groups:

Event Timeline

thcipriani triaged this task as Medium priority.Aug 20 2018, 8:09 PM
thcipriani moved this task from Needs triage to Services improvements on the Scap board.
Restricted Application added a subscriber: Huji. · View Herald TranscriptApr 20 2021, 1:10 AM