Page MenuHomePhabricator

Icon for width toggle is incorrect for anonymous users when enabled
Closed, DeclinedPublic

Description

In T341641#9085898, @Mhurd wrote:

@Jdlrobson Width change persists on reload, but the toggle icon switches back to the wrong state if you reload when it's in fullscreen mode.

ChromeSafari
width toggle state preserved across refresh, but button state wrong - chrome.mov.gif (960×1 px, 1 MB)
width toggle state preserved across refresh, but button state wrong - safari.mov.gif (1×1 px, 1 MB)

qa steps

Make sure you are anonymous
Toggle limited width
Refresh page
Icon is incorrect

developer notes

Option 1

This seems like a good opportunity to remove the JS manipulation of classes and use a codex icon mixin based on classes on document

Option 2

Set icon on page load based on classes on document

Event Timeline

ovasileva triaged this task as Medium priority.Aug 28 2023, 2:07 PM
ovasileva moved this task from Incoming to Current Fiscal Year on the Web-Team-Backlog board.
Jdlrobson changed the task status from Open to Stalled.Oct 2 2023, 6:45 PM

Still a bug, but perhaps not working on given the work on T345363?

ovasileva lowered the priority of this task from Medium to Low.Oct 23 2023, 9:05 AM
ovasileva moved this task from Current Fiscal Year to Groomed on the Web-Team-Backlog board.
aliu changed the task status from Stalled to Open.Jan 12 2024, 9:23 PM
aliu raised the priority of this task from Low to Medium.
aliu subscribed.

@Jdlrobson I presume this isn't stalled now that the Accessibility prototype is finished.

I think it's still stalled, as the idea is that when the accessibility beta feature is released, this will be resolved.
What are you hoping will happen now?

That we fix the icon first while the beta feature is being worked on. From my end it doesn't seem like there were much changes to the beta feature since it shipped.

Jdlrobson lowered the priority of this task from Medium to Low.Jan 17 2024, 1:35 AM
Jdlrobson added a project: patch-welcome.

There have been no changes to the beta feature due to the WMF office being closed and the holiday period. I can assure you things are moving there :-)

I think a patch is welcome here if someone wants to provide one but otherwise it's unlikely to be worked on due to other priorities.

The toggle button is being phased out in favor of the new menu with dark mode and font size