[QA Only] Discussion tool special pages do not work in night mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 3 2024, 7:10 PM

Description

Background

As a user I want night theme on all pages.

User story

As a user I want all my pages in dark mode.

Acceptance criteria

https://en.wikipedia.org/w/index.php?title=Special:DiscussionToolsDebug&vectornightmode=1 works in night theme.
https://en.wikipedia.org/w/index.php?title=Special:FindComment&vectornightmode=1 works in night theme.

Requirement

Ensure that the following discussion tool special pages are functional and display correctly in night mode.

BDD

Feature: Compatibility of Discussion Tool Special Pages with Night Mode

  Scenario: Special:DiscussionToolsDebug works in night mode
    Given the user has enabled night mode
    When the user visits Special:DiscussionToolsDebug
    Then the page should display correctly in dark mode

  Scenario: Special:FindComment works in night mode
    Given the user has enabled night mode
    When the user visits Special:FindComment
    Then the page should display correctly in dark mode

Test Steps

Test Case 1: Verify Special:DiscussionToolsDebug in Night Mode

Enable night mode.
Navigate to Special:DiscussionToolsDebug.
AC1: Confirm that the page displays correctly in dark mode.

Test Case 2: Verify Special:FindComment in Night Mode

Enable night mode.
Navigate to Special:FindComment.
AC2: Confirm that the page displays correctly in dark mode.

QA Results - Beta

AC	Status	Details
1	✅	T366524#9962865

QA Results - Prod

AC	Status	Details
1	✅	T366524#9975763

Details

	Subject	Repo	Branch	Lines +/-
	Fix color contrast issues in DiscussionToolsDebug in night theme	mediawiki/extensions/DiscussionTools	master	+5 -3
	Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)	operations/mediawiki-config	master	+2 -21

Customize query in gerrit

Related Objects

Mentioned In: T368686: Verify 1.43.0-wmf.12 deployment

Event Timeline

Jdlrobson created this task.Jun 3 2024, 7:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 3 2024, 7:10 PM

Jdlrobson triaged this task as High priority.Jun 3 2024, 7:11 PM

Jdlrobson added a project: Web-Team-Backlog.Jun 26 2024, 7:02 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to FY2024-25 Q1 Sprint 1 on the Web-Team-Backlog board.Jun 26 2024, 8:10 PM

Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog.

To review what this looks like on the beta cluster right now before re-prioritizing.

Change #1050486 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/DiscussionTools@master] Fix color contrast issues in DiscussionToolsDebug in night theme

https://gerrit.wikimedia.org/r/1050486

gerritbot added a project: Patch-For-Review.Jun 28 2024, 12:04 AM

https://en.wikipedia.beta.wmflabs.org/wiki/Special:DiscussionToolsDebug?pagetitle=Task+Force+76 has the following issues:

Screenshot 2024-06-27 at 4.49.26 PM.png (570×1 px, 65 KB)

Screenshot 2024-06-27 at 4.49.03 PM.png (747×1 px, 76 KB)

https://en.wikipedia.beta.wmflabs.org/wiki/Special:FindComment?idorname=c-TestEsther-2021-08-12T20%3A36%3A00.000Z-Something_New looks fine.

Change #1049975 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

https://gerrit.wikimedia.org/r/1049975

Change #1049975 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

Reason:

Moved into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671?usp=search

https://gerrit.wikimedia.org/r/1049975

Change #1050486 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix color contrast issues in DiscussionToolsDebug in night theme

https://gerrit.wikimedia.org/r/1050486

Jdlrobson renamed this task from Discussion tool special pages do not work in night mode to [QA Only] Discussion tool special pages do not work in night mode.Jul 1 2024, 4:23 PM

Jdlrobson moved this task from Ready for estimation to Blocked on Others on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2024, 4:32 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jul 1 2024, 5:00 PM

Jdlrobson moved this task from Excluded experiences to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Jul 1 2024, 11:29 PM

GMikesell-WMF mentioned this in T368686: Verify 1.43.0-wmf.12 deployment.Jul 3 2024, 9:38 PM

ovasileva raised the priority of this task from Medium to High.Jul 8 2024, 10:54 AM

Jdlrobson reassigned this task from Jdlrobson to GMikesell-WMF.Jul 8 2024, 5:13 PM

Jdlrobson moved this task from Blocked on Others to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

https://en.wikipedia.org/w/index.php?title=Special:DiscussionToolsDebug&vectornightmode=1 works in night theme

2024-07-08_12-56-18.png (965×1 px, 206 KB)

https://en.wikipedia.org/w/index.php?title=Special:FindComment&vectornightmode=1 works in night theme.

2024-07-08_12-59-16.png (915×1 px, 166 KB)

GMikesell-WMF removed GMikesell-WMF as the assignee of this task.Jul 8 2024, 8:08 PM

GMikesell-WMF assigned this task to ovasileva.

GMikesell-WMF updated the task description. (Show Details)

GMikesell-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

GMikesell-WMF subscribed.

Looks good, resolving. cc @ppelberg

Edtadros updated the task description. (Show Details)Jul 12 2024, 4:15 AM

Edtadros updated the task description. (Show Details)Jul 12 2024, 4:18 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Special:DiscussionToolsDebug in Night Mode

Enable night mode.
Navigate to Special:DiscussionToolsDebug.
✅ AC1: Confirm that the page displays correctly in dark mode.

Test Case 2: Verify Special:FindComment in Night Mode

Enable night mode.
Navigate to Special:FindComment.
✅ AC2: Confirm that the page displays correctly in dark mode.

Edtadros updated the task description. (Show Details)Jul 12 2024, 4:25 AM

	F55936032: Screenshot 2024-06-27 at 4.49.03 PM.png
	Jun 28 2024, 12:04 AM

	F55936047: Screenshot 2024-06-27 at 4.49.26 PM.png
	Jun 28 2024, 12:04 AM

	F56368277: screenshot 151.png
	Jul 12 2024, 4:24 AM

	F56368276: screenshot 149.png
	Jul 12 2024, 4:24 AM

	F56368273: screenshot 150.png
	Jul 12 2024, 4:24 AM

	F56368272: screenshot 148.png
	Jul 12 2024, 4:24 AM

[QA Only] Discussion tool special pages do not work in night modeClosed, ResolvedPublicActions

Description

Background

User story

Acceptance criteria

Requirement

BDD

Test Steps

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

Test Steps

Test Result - Prod

Test Steps

[QA Only] Discussion tool special pages do not work in night mode
Closed, ResolvedPublic
Actions