Page MenuHomePhabricator

Unchanged file with unresolved comment doesn't show up in file list
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

On https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1017814 I added an unresolved comment to src/Hooks/ValidationHooks.php, a file that was not modified in this change so far. You can see the comment if you switch to the "Comments" tab. (And also not the 2 unresolved conversations in the screenshot below.)

What happens?:
The file is not listed in the "Files" tab, despite having an unresolved comment.

What should have happened instead?:
The files should show in the "Files" tab with the note that it has an unresolved comment, so that it is easily visible for any other reviewers and the author of the change.
I distinctively remember that this used to work.

Other information (browser name/version, screenshots, etc.):

Screenshot 2024-04-10 at 19-25-09 tests Improve test coverage (I3e02bba6) · Gerrit Code Review.png (1×2 px, 407 KB)

Event Timeline

hashar updated the task description. (Show Details)
hashar subscribed.

I previously filed a placeholder task T360178 for it but I have not investigated it cause the example change I had was from 2013. If it happens on newer change, well I guess something is indeed really broken :(

Does this work for you now?

@Paladox: Has something related changed server-side in the meantime?

Does this work for you now?

@Paladox: Has something related changed server-side in the meantime?

There was a gerrit update I think shortly after this task was filed.

looking at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1017814/4 I see the comment in ValidationHooks but it's resolved now so I'm not entirely sure if the problem is fixed.

Possibly related - I was complaining yesterday about Gerrit not showing me unresolved comments on a previous version of a file. So I tested a couple of things on /test/gerrit-ping, as suggested by @hashar.

While not directly what's reported (because it happens on a file modified in this review), see also this:

comments-missing-1.png (332×943 px, 34 KB)

Note the discrepancy between the number of unresolved comments and the number of unresolved comments in the files: two of them on test-comments are not displayed there. This happens to previous comments new comments are added to the review, when new comments are moved from draft to real comments ("reply"). A reload of the page seems to solve the issue.

To reproduce on https://gerrit.wikimedia.org/r/c/test/gerrit-ping/+/1057052:

  • add a comment somewhere
  • click Reply and validate
  • it looks like, specifically and regardless of where you put the comments, the comments on test-comments are not visible until the page gets reloaded.

I could see what is reported in this issue being a specific case of a larger issue of "sometimes comments are not shown".

Note: I observe that behaviour both on Firefox and Chrome.