Page MenuHomePhabricator

WikimediaMessages exclude list only applies to default language
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Impact: On Polish and French Wikipedia, content renders inconsistently based on language.

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

  • Styles should not apply - the exclude list is only applying if the language is cs.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Steps:

  1. go to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page in night mode - it should not have colored boxes
  2. go to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?uselang=es in night mode - it should also not have colored boxes

QA Results - Beta

ACStatusDetails
1T367585#9978487

QA Results - PROD

ACStatusDetails
1T367585#9979170

Event Timeline

Jdlrobson updated the task description. (Show Details)

@Jdlrobson is it just me or do the repro steps no longer work?

Repo steps are good, but cs wikipedia is no longer a good example.
https://pl.m.wikipedia.org/wiki/Pary%C5%BC

If working on this given the difference is subtle I'd recommend, adding some kind of obvious style in WikimediaMessages e.g. make the infobox red - to check you can reproduce.

Change #1051823 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/extensions/WikimediaMessages@master] Use content language for wikimedia styles exclusion

https://gerrit.wikimedia.org/r/1051823

I believe I added halfway decent beta QA steps

Change #1051823 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Use content language for wikimedia styles exclusion

https://gerrit.wikimedia.org/r/1051823

Jdlrobson lowered the priority of this task from High to Medium.
Jdlrobson moved this task from Doing to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. go to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page in night mode - it should not have colored boxes
  2. go to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?uselang=es in night mode - it should also not have colored boxes
EnEs
2024-07-12_15-05-29.png (1×1 px, 374 KB)
2024-07-12_15-07-35.png (1×1 px, 384 KB)
GMikesell-WMF assigned this task to ovasileva.
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF subscribed.

@Jdlrobson @Edtadros Do you know how I can test this in PROD since QA's description says to test the Main Page with no color boxes but PROD has all color boxes?

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Go tohttps://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal in night mode - it should not have colored boxes
French
2024-07-13_07-56-58.png (1×1 px, 527 KB)