Page MenuHomePhabricator

mw-collapsible-text should use standard link colors
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The [show]/[hide] links within mw-collapsible elements have color #0645ad in Vector 2022. This is not accessible against the black background of dark mode.

en.wikipedia.org_wiki_Edna_Hibel.png (72×1 px, 14 KB)

They also have a non-standard orange active state

en.wikipedia.org_wiki_Edna_Hibel (1).png (72×1 px, 14 KB)

What should have happened instead?:

These should probably be changed to use the same link colors as the rest of the interface

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1T368498#9952274

QA Results - PROD

ACStatusDetails
1T368498#9970623

Event Timeline

Hey @Pcoombe could you share your screenshots? They are set to private.

I don't think we alter the color of collapsible elements - is it possible these are being set on wiki?

Apologies, I fixed the files

It's defined in resources/src/jquery/jquery.makeCollapsible.less to use the non-Codex variable @color-link, which itself is defined in resources/src/mediawiki.less/mediawiki.skin.defaults.less. Not sure what the best approach to fix this would be.

Change #1050044 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] makeCollapsible: Use Codex link mixin cdx-mixin-link-base

https://gerrit.wikimedia.org/r/1050044

Jdlrobson lowered the priority of this task from High to Medium.

Change #1050044 merged by jenkins-bot:

[mediawiki/core@master] makeCollapsible: Use Codex link mixin cdx-mixin-link-base

https://gerrit.wikimedia.org/r/1050044

Test Result - Beta

Status:
Environment: Beta
OS: macOS Sonoma 14.3
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Screenshot 2024-07-03 at 3.43.32 PM.png (698×1 px, 229 KB)

show/hide buttons match other links.

@Jdlrobson Please review below, thanks!

Test Result - Prod

Status: ❌ FAIL
Environment: Prod
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
show/hide buttons match other links but I was getting color contrast issues
2024-07-09_15-05-54.png (1×3 px, 707 KB)
2024-07-09_15-06-22.png (1×3 px, 713 KB)

show/hide buttons match other links but I was getting color contrast issues

These are unrelated and a separate problem. For QA purposes on this task we only care about the [show] and [hide] links on the right.

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: Prod
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

✅ AC1: See artifacts of previous testing here: T368498#9967484 which is a pass per T368498#9967586