Page MenuHomePhabricator

"Thrown out" votes in SecurePoll are difficult to distinguish from live votes
Closed, DuplicatePublic

Description

Currently old vote in Special:ecurePoll/list use #666 as color, which is kind of hard to distinguish from valid(latest) vote. Propose to change it to #AAA - same as closed election - for a better appearance.

Event Timeline

Change 793802 had a related patch set uploaded (by Stang; author: Stang):

[mediawiki/extensions/SecurePoll@master] Color adjustment for old vote

https://gerrit.wikimedia.org/r/793802

#AAAAAA unfortunately fails the WCAG contrast test: https://webaim.org/resources/contrastchecker/?fcolor=AAAAAA&bcolor=FFFFFF

Perhaps there could be some other colour, or another way to differentiate these older votes (italic text perhaps)

jrbs renamed this task from Color adjustment for old vote to "Thrown out" votes in SecurePoll are difficult to distinguish from live votes.Jun 17 2022, 5:00 PM
jrbs added a project: Accessibility.
Stang triaged this task as Medium priority.Jul 24 2022, 7:04 PM
This comment was removed by Stang.

There exist two CSS classes called securepoll-old-vote and securepoll-struck-vote. I thought the red color would be more acceptable for the striked vote instead of the old previous vote, as red color normally indicate something wrong happened. I disagree with using italic too much, some scripts (CJK or something else) don't use italic.
Another thing is the delete line for stuck vote is a little bit thin, and it would be better if text-decoration-thickness: from-font; rule is added to class securepoll-struck-vote.

Change 886466 had a related patch set uploaded (by Foks; author: Foks):

[mediawiki/extensions/SecurePoll@master] SecurePoll: Changing struck and thrown out colours

https://gerrit.wikimedia.org/r/886466

My proposal (the patch above) looks like this. Thrown out votes are struck-through, and struck votes are red:

SS 2023-02-04 at 7.24.17 pm.png (378×530 px, 25 KB)

As a color-blind person, I can't easily distinguish the red color in the proposal by @jrbs, and I'm a bit confused. It looks to me like the color of the text for JSutherland in that example is different from that for ClydeFranklin - but perhaps just because the background is different? What does the background signify? If the red color and the strikethru indications are redundant with each other, it's probably ok.
Thanks.

Change #886466 abandoned by Huji:

[mediawiki/extensions/SecurePoll@master] SecurePoll: Changing struck and thrown out colours

Reason:

Abandoning in favor of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/1037853

https://gerrit.wikimedia.org/r/886466

Change #793802 abandoned by Huji:

[mediawiki/extensions/SecurePoll@master] Style adjustment for struck vote and old vote

Reason:

Abandoning given https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/1037855

https://gerrit.wikimedia.org/r/793802