Page MenuHomePhabricator
Create Task
Maniphest T322959

QuizGame: Call to undefined method Wikimedia\Rdbms\DatabaseMysqli
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Install and enable QuizGame
  • Navigate to Special:QuizGameHome

What happens?:

Call to undefined method Wikimedia\Rdbms\DatabaseMysqli::useIndexClause()
from /srv/mediawiki/w/includes/libs/rdbms/database/DBConnRef.php(103)
#0 /srv/mediawiki/w/extensions/QuizGame/includes/specials/SpecialQuizGameHome.php(191): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#1 /srv/mediawiki/w/extensions/QuizGame/includes/specials/SpecialQuizGameHome.php(884): QuizGameHome->getNextQuestion()
#2 /srv/mediawiki/w/extensions/QuizGame/includes/specials/SpecialQuizGameHome.php(126): QuizGameHome->launchGame()
#3 /srv/mediawiki/w/includes/specialpage/SpecialPage.php(701): QuizGameHome->execute(NULL)
#4 /srv/mediawiki/w/includes/specialpage/SpecialPageFactory.php(1428): SpecialPage->run(NULL)
#5 /srv/mediawiki/w/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#6 /srv/mediawiki/w/includes/MediaWiki.php(904): MediaWiki->performRequest()
#7 /srv/mediawiki/w/includes/MediaWiki.php(562): MediaWiki->main()
#8 /srv/mediawiki/w/index.php(50): MediaWiki->run()
#9 /srv/mediawiki/w/index.php(46): wfIndexMain()
#10 {main}

What should have happened instead?:
Page should've worked as intended

Software version (skip for WMF-hosted wikis like Wikipedia):
Product Version
MediaWiki 1.39.0-rc.1 (d502ed1)
PHP 7.4.30 (fpm-fcgi)
MariaDB 10.5.17-MariaDB-1:10.5.17+maria~deb11-log

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
SpecialQuizGameHome: Remove usage of useIndexClause()mediawiki/extensions/QuizGamemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Reception123 created this task.Nov 12 2022, 10:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2022, 10:00 AM
Maintenance_bot added a project: Social-Tools.Nov 12 2022, 10:29 AM
ashley added subscribers: Ladsgroup, ashley.Nov 13 2022, 2:53 PM

@Ladsgroup So while investigating this ticket I stumbled upon T307616 and your dd9b44b167141, which removed the useIndexClause method but it looks like it was accidental as there was no mention of it in the commit message, and the method was neither deprecated nor marked as private. Can you confirm whether this was truly the case, and if so, could the method be added back to the relevant core class in order to fix this issue? Thanks!

Universal_Omega added a comment.Nov 13 2022, 4:19 PM
In T322959#8390906, @ashley wrote:

@Ladsgroup So while investigating this ticket I stumbled upon T307616 and your dd9b44b167141, which removed the useIndexClause method but it looks like it was accidental as there was no mention of it in the commit message, and the method was neither deprecated nor marked as private. Can you confirm whether this was truly the case, and if so, could the method be added back to the relevant core class in order to fix this issue? Thanks!

Oh. Thanks for finding that also, I looked for about 30 minutes yesterday and couldn't find where it was removed as I couldn't find any mention either.

gerritbot added a comment.Jan 11 2023, 6:06 PM

Change 879096 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/extensions/QuizGame@master] SpecialQuizGameHome: Remove usage of useIndexClause()

https://gerrit.wikimedia.org/r/879096

gerritbot added a project: Patch-For-Review.Jan 11 2023, 6:06 PM
gerritbot added a comment.Jan 11 2023, 7:03 PM

Change 879096 merged by Universal Omega:

[mediawiki/extensions/QuizGame@master] SpecialQuizGameHome: Remove usage of useIndexClause()

https://gerrit.wikimedia.org/r/879096

Universal_Omega closed this task as Resolved.Jan 11 2023, 7:04 PM
Universal_Omega claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Jan 11 2023, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits